-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature previews #4079
Feature previews #4079
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't provider be added to storybook as well?
src/components/Sidebar/user/FeatureFlagsModal/usePersistance.ts
Outdated
Show resolved
Hide resolved
401230c
The feature preview button should always open a list of feature flags - now user need to release user account modal to get back to list view if visible flag is set to false 261031419-2be62d8f-4b97-46d7-8c47-373aee5df4b2.mov |
AC:
user menu -> feature previews
enable: true
within markdown attributes sectionvisible: false
in markdown, flag will not be visible in the feature preview modalNotes:
after making changes within markdown files (add new one, edit etc.) please run
npm run build-flags
- it will generate the contentScreenshots
Pull Request Checklist
data-test-id
are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2