Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature previews #4079

Merged
merged 15 commits into from
Aug 17, 2023
Merged

Feature previews #4079

merged 15 commits into from
Aug 17, 2023

Conversation

andrzejewsky
Copy link
Member

@andrzejewsky andrzejewsky commented Aug 11, 2023

AC:

  • All available feature flags (feature previews) should be available within the modal, toggled from the user menu -> feature previews
  • User should be able to enable or disable the feature
  • Developer is able to create markdown file with new feature along with its description and image
  • Developer can enable flag by default by setting enable: true within markdown attributes section
  • When developer set visible: false in markdown, flag will not be visible in the feature preview modal
  • When there is no flag, modal shows proper information about it

Notes:
after making changes within markdown files (add new one, edit etc.) please run npm run build-flags - it will generate the content

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@andrzejewsky andrzejewsky requested review from a team, krzysztofzuraw and Droniu August 11, 2023 14:54
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: fa82773

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to feature-previews August 11, 2023 14:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 11, 2023 14:55 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 11, 2023 14:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 11, 2023 14:58 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 14, 2023 08:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 14, 2023 08:35 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 14, 2023 08:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 14, 2023 08:37 Inactive
Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't provider be added to storybook as well?

krzysztofzuraw
krzysztofzuraw previously approved these changes Aug 14, 2023
Droniu
Droniu previously approved these changes Aug 14, 2023
@andrzejewsky andrzejewsky dismissed stale reviews from Droniu and krzysztofzuraw via 401230c August 16, 2023 07:35
@github-actions github-actions bot temporarily deployed to feature-previews August 16, 2023 07:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 16, 2023 07:36 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 16, 2023 07:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 16, 2023 07:48 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 16, 2023 10:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 16, 2023 10:35 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 16, 2023 11:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 16, 2023 11:20 Inactive
@wojteknowacki
Copy link
Member

wojteknowacki commented Aug 16, 2023

The feature preview button should always open a list of feature flags - now user need to release user account modal to get back to list view if visible flag is set to false

261031419-2be62d8f-4b97-46d7-8c47-373aee5df4b2.mov

krzysztofzuraw
krzysztofzuraw previously approved these changes Aug 16, 2023
@wojteknowacki
Copy link
Member

  • When multiple flags are present list is not scrollable
  • When log text added as description last line is fully visible
    image

@github-actions github-actions bot temporarily deployed to feature-previews August 16, 2023 14:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 16, 2023 14:52 Inactive
@github-actions github-actions bot temporarily deployed to feature-previews August 17, 2023 07:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-previews August 17, 2023 07:54 Inactive
@andrzejewsky andrzejewsky merged commit aaf6463 into main Aug 17, 2023
@andrzejewsky andrzejewsky deleted the feature-previews branch August 17, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants