Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing only first 50 warehouses at variant page #4136

Merged
merged 7 commits into from
Aug 29, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Aug 28, 2023

closes #4133

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=5

@poulch poulch requested review from a team, andrzejewsky and Droniu August 28, 2023 14:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 4e77e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@poulch poulch requested a review from krzysztofzuraw August 28, 2023 14:17
@github-actions github-actions bot temporarily deployed to 4133-fix-missing-pagination-on-warehouse August 28, 2023 14:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4133-fix-missing-pagination-on-warehouse August 28, 2023 14:17 Inactive
@poulch poulch changed the title Fix missing pagination on warehouse list in variant page Fix showing only first 50 warehouses at variant page Aug 28, 2023
@github-actions github-actions bot temporarily deployed to 4133-fix-missing-pagination-on-warehouse August 28, 2023 14:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4133-fix-missing-pagination-on-warehouse August 28, 2023 14:19 Inactive
Droniu
Droniu previously approved these changes Aug 28, 2023
src/hooks/makeFetchAll.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to 4133-fix-missing-pagination-on-warehouse August 28, 2023 19:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4133-fix-missing-pagination-on-warehouse August 28, 2023 19:33 Inactive
@poulch poulch requested a review from Droniu August 29, 2023 07:22
@poulch poulch added the run e2e Runs cypress end-to-end tests label Aug 29, 2023
@github-actions github-actions bot temporarily deployed to 4133-fix-missing-pagination-on-warehouse August 29, 2023 08:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4133-fix-missing-pagination-on-warehouse August 29, 2023 08:59 Inactive
@poulch poulch merged commit e1b250d into main Aug 29, 2023
@poulch poulch deleted the 4133-fix-missing-pagination-on-warehouse branch August 29, 2023 11:19
@poulch poulch restored the 4133-fix-missing-pagination-on-warehouse branch July 1, 2024 11:27
@poulch poulch deleted the 4133-fix-missing-pagination-on-warehouse branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run e2e Runs cypress end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing pagination on warehouse list in variant page
3 participants