Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty date filter on order list #4226

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix empty date filter on order list #4226

merged 2 commits into from
Sep 22, 2023

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Sep 22, 2023

I want to merge this change because it fixes error when applying empty date filter on order list

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@Droniu Droniu requested review from a team, andrzejewsky and poulch September 22, 2023 08:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: dd93368

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Droniu Droniu added bug Something isn't working view: order labels Sep 22, 2023
@Droniu Droniu merged commit 0f8a6cd into main Sep 22, 2023
21 of 22 checks passed
@Droniu Droniu deleted the fix-date-filter-order-list branch September 22, 2023 10:59
Droniu added a commit that referenced this pull request Sep 22, 2023
* Fix empty date filter on order list

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working view: order
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants