Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voucher codes with API #4316

Merged
merged 112 commits into from
Nov 9, 2023
Merged

Voucher codes with API #4316

merged 112 commits into from
Nov 9, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Oct 10, 2023 •
edited
Loading

closes #4182

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=6

poulch added 30 commits September 12, 2023 14:04
@poulch
Init voucher codes datagrid
123631f
@poulch
Submenu
66792f3
@poulch
Change dropdown button
9455b90
@poulch
Delete voucher codes dialog
b9870ef
@poulch
Generate voucher codes dialog
5425cf0
@poulch
Allow only dgits in voucher generate modal quantity field
c69b6f7
@poulch
Update storybook props
de26f87
@poulch
Add more codes
4459f44
@poulch
Merge branch 'main' into 4182-voucher-codes-datagrid
3a60268
@poulch
Update schema
7fd5b00
@poulch
Fetch voucher codes
2967e29
@poulch
Add manual voucher code modal
2fae9d6
@poulch
Add manual voucher code
e3f55a1
@poulch
Update prosp and fixtures
81291aa
@poulch
Remove delete codes from datgrid menu item
c5c8720
@poulch
Refactor components
453895c
@poulch
Bulk voucher delete by row selection
be939f0
@poulch
Handle add manual voucher code form data
b8255bb
@poulch
Use separate query to fetch codes
6683265
@poulch
Pagination wip
f85e74f
@poulch
Clear add manual code after submit
858246d
@poulch
Block dots in usage input
0a921b0
@poulch
Refetch voucher codes when update
e8def68
@poulch
Code refactor, replace any types
403d298
@poulch
Update fixture
cc99b15
@poulch
Merge branch 'main' into 4182-voucher-codes-datagrid
1e08eb6
@poulch
Add changeset
eaba340
@poulch
Remove VoucherLimit from details page
edf8b45
@poulch
No poiner in ddatagrid, add placeholder in case of no data
6afdeeb
@poulch
Revert "Remove VoucherLimit from details page"
88bc81b 
This reverts commit edf8b45.
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 7, 2023 16:36 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4182-voucher-codes-with-api November 7, 2023 16:36 Destroyed
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 7, 2023 16:53 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4182-voucher-codes-with-api November 7, 2023 16:53 Destroyed
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 7, 2023 16:56 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4182-voucher-codes-with-api November 7, 2023 16:56 Destroyed
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 8, 2023 14:11 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4182-voucher-codes-with-api November 8, 2023 14:11 Destroyed
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 8, 2023 14:53 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4182-voucher-codes-with-api November 8, 2023 14:53 Destroyed
@wojteknowacki wojteknowacki self-requested a review November 8, 2023 15:03
wojteknowacki
wojteknowacki previously approved these changes Nov 8, 2023
View reviewed changes
@wojteknowacki wojteknowacki self-requested a review November 8, 2023 15:05
@github-actions github-actions bot temporarily deployed to 4182-voucher-codes-with-api November 8, 2023 15:07 Destroyed
@poulch poulch merged commit 926a74b into main Nov 9, 2023
20 checks passed
@poulch poulch deleted the 4182-voucher-codes-with-api branch November 9, 2023 08:39
@poulch poulch restored the 4182-voucher-codes-with-api branch July 1, 2024 11:26
@poulch poulch deleted the 4182-voucher-codes-with-api branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojteknowacki wojteknowacki wojteknowacki approved these changes

@Droniu Droniu Droniu approved these changes

@andrzejewsky andrzejewsky Awaiting requested review from andrzejewsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Voucher codes manipulation
3 participants
@poulch @wojteknowacki @Droniu