Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused get info request in side settings scenario #4358

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

wojteknowacki
Copy link
Member

Removed useless shop info query from site settings tests

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 75d6664

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to e2e-maintenance-shop-info October 20, 2023 12:12 Destroyed
@github-actions github-actions bot temporarily deployed to storybook e2e-maintenance-shop-info October 20, 2023 12:12 Destroyed
@github-actions github-actions bot temporarily deployed to e2e-maintenance-shop-info October 20, 2023 12:14 Destroyed
@github-actions github-actions bot temporarily deployed to storybook e2e-maintenance-shop-info October 20, 2023 12:14 Destroyed
@wojteknowacki wojteknowacki marked this pull request as ready for review October 20, 2023 12:16
@wojteknowacki wojteknowacki requested review from a team, andrzejewsky and poulch October 20, 2023 12:16
@github-actions github-actions bot temporarily deployed to e2e-maintenance-shop-info October 20, 2023 12:17 Destroyed
@michalina-graczyk michalina-graczyk merged commit dcb3ebb into main Oct 20, 2023
11 checks passed
@michalina-graczyk michalina-graczyk deleted the e2e-maintenance-shop-info branch October 20, 2023 12:27
@andrzejewsky andrzejewsky changed the title e2e tests - remove shop info request Removed unused get info request in side settings scenario Oct 25, 2023
@wojteknowacki wojteknowacki added this to the Saleor 3.18 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants