Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending attibutes on variant create/update in datagrid on product details page #4361

Merged
merged 14 commits into from
Oct 31, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Oct 20, 2023

closes #2470

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: b963be0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 20, 2023 16:28 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 20, 2023 16:28 Destroyed
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 20, 2023 16:30 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 20, 2023 16:30 Destroyed
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 20, 2023 16:32 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 20, 2023 16:32 Destroyed
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 23, 2023 07:15 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 23, 2023 07:15 Destroyed
@poulch poulch marked this pull request as ready for review October 23, 2023 07:15
@poulch poulch requested review from a team, andrzejewsky and Droniu October 23, 2023 07:15
Droniu
Droniu previously approved these changes Oct 24, 2023
src/utils/ts.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 24, 2023 09:45 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 24, 2023 09:45 Destroyed
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 24, 2023 12:43 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 24, 2023 12:43 Destroyed
@poulch poulch requested a review from Droniu October 24, 2023 12:45
Droniu
Droniu previously approved these changes Oct 24, 2023
andrzejewsky
andrzejewsky previously approved these changes Oct 25, 2023
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 26, 2023 07:07 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 26, 2023 07:07 Destroyed
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 26, 2023 09:51 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 26, 2023 09:51 Destroyed
@poulch poulch dismissed stale reviews from Droniu and andrzejewsky via 2aa97bb October 30, 2023 07:56
@github-actions github-actions bot temporarily deployed to 2470-fix-create-variant-error October 30, 2023 07:57 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 2470-fix-create-variant-error October 30, 2023 07:57 Destroyed
@wojteknowacki wojteknowacki self-requested a review October 30, 2023 14:19
@poulch poulch merged commit 5dffd6e into main Oct 31, 2023
15 checks passed
@poulch poulch deleted the 2470-fix-create-variant-error branch October 31, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating variants error on datagrid
4 participants