Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay home queries to be non-blocking for the UI #4405

Merged
merged 17 commits into from
Nov 10, 2023
Merged

Conversation

poulch
Copy link
Member

@poulch poulch commented Nov 6, 2023

closes #4392

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=3

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: d844128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 6, 2023 12:50 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 6, 2023 12:50 Destroyed
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 7, 2023 09:27 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 7, 2023 09:27 Destroyed
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 7, 2023 09:31 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 7, 2023 09:31 Destroyed
@poulch poulch changed the title [WIP] Delay home queries to be non-blocking for the UI Delay home queries to be non-blocking for the UI Nov 7, 2023
@poulch poulch marked this pull request as ready for review November 7, 2023 09:36
@poulch poulch requested review from a team, andrzejewsky and Droniu November 7, 2023 09:36
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 7, 2023 09:37 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 7, 2023 09:37 Destroyed
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 7, 2023 09:42 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 7, 2023 09:42 Destroyed
Droniu
Droniu previously approved these changes Nov 7, 2023
Copy link
Member

@Droniu Droniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 7, 2023 20:35 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 7, 2023 20:35 Destroyed
src/home/views/index.tsx Outdated Show resolved Hide resolved
andrzejewsky
andrzejewsky previously approved these changes Nov 8, 2023
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 9, 2023 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 9, 2023 11:52 Destroyed
@wojteknowacki wojteknowacki dismissed stale reviews from Droniu and andrzejewsky via e42f4d3 November 9, 2023 11:54
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 9, 2023 11:54 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 9, 2023 11:54 Destroyed
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 9, 2023 12:20 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 9, 2023 12:20 Destroyed
@github-actions github-actions bot temporarily deployed to 4392-delay-home-queries November 9, 2023 22:11 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4392-delay-home-queries November 9, 2023 22:11 Destroyed
@poulch poulch merged commit 9f83d90 into main Nov 10, 2023
16 checks passed
@poulch poulch deleted the 4392-delay-home-queries branch November 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Delay home queries to be non-blocking for the UI
4 participants