-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay home queries to be non-blocking for the UI #4405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d844128 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 6, 2023 12:50
Destroyed
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 7, 2023 09:27
Destroyed
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 7, 2023 09:31
Destroyed
poulch
changed the title
[WIP] Delay home queries to be non-blocking for the UI
Delay home queries to be non-blocking for the UI
Nov 7, 2023
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 7, 2023 09:37
Destroyed
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 7, 2023 09:42
Destroyed
Droniu
previously approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 7, 2023 20:35
Destroyed
andrzejewsky
requested changes
Nov 8, 2023
andrzejewsky
previously approved these changes
Nov 8, 2023
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 9, 2023 11:52
Destroyed
wojteknowacki
dismissed stale reviews from Droniu and andrzejewsky
via
November 9, 2023 11:54
e42f4d3
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 9, 2023 11:54
Destroyed
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 9, 2023 12:20
Destroyed
github-actions
bot
temporarily deployed
to
storybook 4392-delay-home-queries
November 9, 2023 22:11
Destroyed
github-actions
bot
temporarily deployed
to
4392-delay-home-queries
November 10, 2023 07:53
Destroyed
wojteknowacki
approved these changes
Nov 10, 2023
Droniu
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4392
Screenshots
Pull Request Checklist
data-test-id
are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=3