Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4440-refactor-code-any-type-in-form-events-and-inputs #4441

Merged
merged 7 commits into from
Nov 21, 2023
Merged

4440-refactor-code-any-type-in-form-events-and-inputs #4441

merged 7 commits into from
Nov 21, 2023

Conversation

HigorSantiago
Copy link
Contributor

closes #4440

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@HigorSantiago HigorSantiago requested review from a team, andrzejewsky and Droniu November 15, 2023 00:58
Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 0fd15d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing - please accept CLA

@andrzejewsky andrzejewsky self-requested a review November 21, 2023 13:15
@andrzejewsky andrzejewsky merged commit b5d5740 into saleor:main Nov 21, 2023
10 checks passed
poulch pushed a commit that referenced this pull request Dec 19, 2023
* 4440-refactor-code-any-type-in-form-events-and-inputs

* 4440-refactor-code-any-type-in-form-events-and-inputs

* 4440-refactor-code-any-type-in-form-events-and-inputs

* 4440-refactor-code-any-type-in-form-events-and-inputs

* 4440-refactor-code-any-type-in-form-events-and-inputs

* Create warm-files-reflect.md

---------

Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Refactor code any type in form events, inputs and routes
3 participants