Test bulk delete on product list #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: caef1e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
pr-delete-multiple-product-test
github-actions
bot
temporarily deployed
to
storybook pr-delete-multiple-product-test
wojteknowacki
changed the title
wojteknowacki
requested review from
karola312,
yellowee and
michalina-graczyk
yellowee
previously approved these changes
Dec 4, 2023
poulch
previously approved these changes
Dec 4, 2023
playwright/pages/basePage.ts
Outdated
Comment on lines
131
to
133
| const rows = await this.page.$$eval("table tr", rows => | ||
| rows.map(row => row.textContent), | ||
| ); |
There was a problem hiding this comment.
question: do you have to do this every time in the loop?
There was a problem hiding this comment.
I think so - I try to match the array of strings with the rows so I have to go through all of array elements. When I tried to assign rows and then use eval on it I faced Property $$eval does not exist on type 'Locator'.ts
There was a problem hiding this comment.
I did check it again and you were right 👍
github-actions
bot
temporarily deployed
to
pr-delete-multiple-product-test
github-actions
bot
temporarily deployed
to
storybook pr-delete-multiple-product-test
andrzejewsky
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #...
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2