Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assertion text within channels checkbox in e2e tests #4585

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Change assertion text within channels checkbox in e2e tests #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e99c0b
to detailed copy fix
wojteknowacki Jan 3, 2024
a4d9ad1
Update fast-badgers-wink.md
wojteknowacki Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-badgers-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": minor
---

Change assertion text within channels checkbox in e2e tests
2 changes: 1 addition & 1 deletion playwright/data/copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export const AVAILABILITY = {
in1OutOf7Channels: "In 1 out of 7 channels",
in1OutOf: "In 1 out of",
};
2 changes: 1 addition & 1 deletion playwright/tests/discountAndVouchers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ test("TC: SALEOR_85 Create voucher with manual code and percentage discount @vou
`Given codes: ${code} should have status Active displayed on grid`,
).toEqual(1);
await vouchersPage.page
.getByText(AVAILABILITY.in1OutOf7Channels)
.getByText(AVAILABILITY.in1OutOf)
.waitFor({ state: "visible" });
});

Expand Down
2 changes: 1 addition & 1 deletion playwright/tests/product.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ test("TC: SALEOR_46 As an admin, I should be able to update a product by uploadi
await expect(
productPage.productAvailableInChannelsText,
"Label copy shows 1 out of 7 channels ",
).toContainText(AVAILABILITY.in1OutOf7Channels);
).toContainText(AVAILABILITY.in1OutOf);
expect(
await productPage.productImage.count(),
"Newly added single image should be present",
Expand Down
Loading