Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discount condition when no items to select and stop sending empty condtion #4603

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jan 8, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: af5b409

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@poulch poulch self-assigned this Jan 8, 2024
@github-actions github-actions bot temporarily deployed to storybook pr-4603 January 8, 2024 07:17 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4603 January 8, 2024 07:17 Destroyed
@poulch poulch marked this pull request as ready for review January 9, 2024 13:02
@poulch poulch requested review from a team, andrzejewsky and Droniu January 9, 2024 13:02
@poulch poulch changed the title Improvements for catalog discounts v2 Improve discount condition when no items to select and stop sending empty condtion Jan 9, 2024
@github-actions github-actions bot temporarily deployed to storybook pr-4603 January 10, 2024 08:25 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4603 January 10, 2024 08:25 Destroyed
@poulch poulch merged commit 39711fe into main Jan 10, 2024
16 checks passed
@poulch poulch deleted the discount-catalog-improvments branch January 10, 2024 14:11
andrzejewsky pushed a commit that referenced this pull request Jan 12, 2024
…mpty condtion (#4603)

* Stop send empty conditions

* Bump macaw

* Add NoOptions support to combobox and multiselect

* Show NoOptions in rule conditions

* Extract messages

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants