Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] [E2E] Tests for updating and deleting promotion rules #4722

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[TEST] [E2E] Tests for updating and deleting promotion rules #4722

merged 1 commit into from
Mar 21, 2024

Conversation

yellowee
Copy link
Contributor

Covered test cases:

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@yellowee yellowee self-assigned this Mar 12, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 43e7317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 12, 2024 09:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 12, 2024 09:29 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from 9845a42 to 6ff5eae Compare March 12, 2024 09:33
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 12, 2024 09:35 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 12, 2024 09:35 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch 3 times, most recently from 9e0d50a to e541a49 Compare March 12, 2024 11:35
@github-actions github-actions bot temporarily deployed to pr-4722 March 12, 2024 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 12, 2024 13:15 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from e541a49 to c0e8daf Compare March 12, 2024 14:45
@github-actions github-actions bot temporarily deployed to pr-4722 March 12, 2024 14:48 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 12, 2024 14:48 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 13, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 13, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 13, 2024 13:59 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 13, 2024 14:00 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from c0e8daf to d8d164c Compare March 13, 2024 15:24
@github-actions github-actions bot temporarily deployed to pr-4722 March 13, 2024 15:27 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 13, 2024 15:27 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from d8d164c to bea8421 Compare March 14, 2024 12:00
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 14, 2024 12:05 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 14, 2024 12:05 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from bea8421 to cc8b89d Compare March 14, 2024 13:51
@github-actions github-actions bot temporarily deployed to storybook pr-4722 March 14, 2024 13:54 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4722 March 14, 2024 13:54 Destroyed
@yellowee yellowee requested a review from szczecha March 20, 2024 10:22
szczecha
szczecha previously approved these changes Mar 20, 2024
View reviewed changes
karola312
karola312 previously approved these changes Mar 20, 2024
View reviewed changes
@yellowee yellowee dismissed stale reviews from karola312 and szczecha via 266f9bf March 20, 2024 11:32
@yellowee yellowee force-pushed the test_promotion_rules_update branch from 9ac9c24 to 266f9bf Compare March 20, 2024 11:32
@github-actions github-actions bot temporarily deployed to pr-4722 March 20, 2024 11:36 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from 266f9bf to 7f35939 Compare March 20, 2024 12:34
@github-actions github-actions bot temporarily deployed to pr-4722 March 20, 2024 12:38 Destroyed
poulch
poulch previously approved these changes Mar 20, 2024
View reviewed changes
@yellowee yellowee force-pushed the test_promotion_rules_update branch from 7f35939 to c009a10 Compare March 21, 2024 07:15
@github-actions github-actions bot temporarily deployed to pr-4722 March 21, 2024 07:17 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from c009a10 to 397e55a Compare March 21, 2024 07:36
@github-actions github-actions bot temporarily deployed to pr-4722 March 21, 2024 07:38 Destroyed
@yellowee yellowee force-pushed the test_promotion_rules_update branch from 397e55a to 43e7317 Compare March 21, 2024 07:54
szczecha
szczecha reviewed Mar 21, 2024
View reviewed changes
playwright/data/e2eTestData.ts
Comment on lines 29 to +34
id: "UHJvbW90aW9uOjI0MGVkZGVkLWYzMTAtNGUzZi1iNTlmLTFlMGFkYWE2ZWFkYg=="
},
promotionWithoutRulesToBeDeleted: {
id: "UHJvbW90aW9uOjRmNTQwMDc1LTZlZGMtNDI1NC1hY2U2LTQ2MzdlMGYxZWJhOA==",
name: "e2e Order predicate promotion without rules",
type: "Order",
Copy link
Member

@szczecha szczecha Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix formatting in this file?

@yellowee yellowee merged commit 66f565d into main Mar 21, 2024
14 of 15 checks passed
@yellowee yellowee deleted the test_promotion_rules_update branch March 21, 2024 08:29
This was referenced Apr 2, 2024
Closed
Closed
yellowee added a commit that referenced this pull request Jun 12, 2024
@yellowee
adding tests for promotion rules (#4722)
7e4927e
yellowee added a commit that referenced this pull request Jun 21, 2024
@yellowee
adding tests for promotion rules (#4722)
eb8180a
yellowee added a commit that referenced this pull request Jun 25, 2024
@yellowee
adding tests for promotion rules (#4722)
54a115f
yellowee added a commit that referenced this pull request Jun 26, 2024
@yellowee
adding tests for promotion rules (#4722)
9e54f30
yellowee added a commit that referenced this pull request Jun 26, 2024
@yellowee @wojteknowacki
@karola312 @szczecha @michalina-graczyk
[QA] [E2E] Backporting Playwright tests to 3.19 (#4947)
6f91338 
* cherry-pick c14402c

* cherry-pick b415834

* cherry-pick c956f35

* cherry pick 621c368

* cherry-pick 7c7c73c

* cherry pick 6f6e5ef

* cherry pick 465aa7b

* cherry-pick 8d30330

* cherry pick 1dcb956

* cherry pick f845150

* cherry pick 563b865

* cherry-pick dbfe9b7

* [E2E] Add tests for translations (#4723)

* add changeset

* add ttest for add and edit translation

* add test for celaring translation

* cherry pick 202b18f

* adding tests for promotion rules (#4722)

* cherry pick a47581e

* [E2E] Fixing flaky e2e tests (#4751)

* adding extra assertion to translation tests

* updating assertion in attribute tests

* modifying assertions for gift card tests

* [E2E] Fixing another batch of flaky tests (#4756)

* updating tests for extra assertions and adding skip to App test

* updating tests for extra assertions

* updating tests for extra assertions and temporarily commenting not working assertions

* adding PW test for readonly Apps access (#4755)

* cherry pick bde2fe8

* add siteSettings basic test (#4759)

* cherry pick ec21ae3

* cherry pick f25bf71

* cherry pick 08b55d4

* cherry pick 5f1ac2a

* cherry pick ae560bf

* cherry pick 024f2d0

* [E2E] Tests for product types (#4757)

* initial commit with changelog

* add test for update product type

* add test to delete several product types

* add test to remove product type with asigned product

* fix numering and assertion after removing types

* typo

* update test data

* add assertions

* [E2E] Use dummy app in delete app test (#4789)

* replace app

* update test data

* fixing flaky gift cards tests (#4785)

* cherry pick 2b0f760

* updating and removing gh workflows and actions (#4823)

* adding back tests-nightly workflow (#4827)

* cherry pick cb5988f

* cherry pick 7b7f222

* cherry pick a6ed457

* cherry pick 6c5be66

* Fix flaky test - TC: SALEOR_205 Bulk delete customers (#4845)

* cherry pick be40ffd

* cherry pick f6d44a9

* cherry pick 06678d0

* cherry pick 618bb01

* cherry pick dd8d60a

* cherry pick 70b2c40

* cherry pick c956f35

* cherry pick b415834

* cherry pick c14402c

* updating test data

* changeset

* updating gh action

* testing snapshot data

---------

Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com>
Co-authored-by: Karolina Rakoczy <karolina.rakoczy@saleor.io>
Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com>
Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szczecha szczecha szczecha approved these changes

@poulch poulch poulch approved these changes

@karola312 karola312 karola312 left review comments

Assignees

@yellowee yellowee

Labels
automation tests e2e-migration
Projects
Dashboard
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yellowee @karola312 @poulch @szczecha