Allow user without app permission access apps view #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 452e391 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
poulch
force-pushed
the
merx-88-remove-app-permission
branch
from
0fc873f to
83f496d
Compare
…eor-dashboard into merx-88-remove-app-permission
krzysztofzuraw
approved these changes
Mar 27, 2024
andrzejewsky
approved these changes
Mar 27, 2024
andrzejewsky
requested review from
yellowee
and removed request for
michalina-graczyk
yellowee
approved these changes
Mar 27, 2024
This was referenced Apr 2, 2024
karola312
pushed a commit
that referenced
this pull request
Apr 5, 2024
* Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests
poulch
added a commit
that referenced
this pull request
Apr 10, 2024
* Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests
karola312
added a commit
that referenced
this pull request
May 7, 2024
* Test PR - running playwright tests after deployment * Test PR - running playwright tests after deployment * Rerun job * open draft PR * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Check if PR exist * Check if PR exist * Check if PR exist * Check if PR exist * restore data from snapshot * Allow user without app permission access apps view (#4738) * Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests * [E2E] Fixing flaky e2e tests (#4751) * adding extra assertion to translation tests * updating assertion in attribute tests * modifying assertions for gift card tests * [E2E] Fixing another batch of flaky tests (#4756) * updating tests for extra assertions and adding skip to App test * updating tests for extra assertions * updating tests for extra assertions and temporarily commenting not working assertions * adding PW test for readonly Apps access (#4755) * [QA] Correcting e2e test case ids (#4764) * correcting test case ids * fixing flaky test * Update .changeset/serious-books-wave.md Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> --------- Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> * New github action for gathering metrics (#4762) * New github action for metrics gathering * metrics file name containing date * search query repo update * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> * Update repo-metrics.yml * Update repo-metrics.yml * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> --------- Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Gathering pull requests metrics (#4766) * fix workflow dispatch trigger * fix workflow dispatch trigger * metrics for pr * removed date from file name * on push added * wip * date in issue name, workflow dispatch trigger * Create long-keys-compare.md * add siteSettings basic test (#4759) * Remove babel (#4711) * Remove babel * Add changeset * Fix showing empty tooltip when no content by bumping macaw-ui to newest (#4771) * Bump macaw * Add changeset * [E2E] Tests for page types (#4765) * add changeset * add test data * add tests and update data-test-id * code review fixes * spaces * adding test for permission groups (#4758) * fixing flaky tests (#4772) * Send tests results when running manually (#4737) * Send tests results when running manually * Send tests results when running manually * Send tests results when running manually * Check if it is working * Fix init testmo * Fix submit threads * Fix working directory when sending results to testmo * Add name and tag * Add name and tag * Fix run name * Add reports when tests run by cron * Fix messages skip ci * Fix messages [skip ci] * Sending playwright tests results to slack and testmo * Update .github/workflows/tests-nightly.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * changes fter review * fix changeset --------- Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Fix version * Run tests * Run tests on correct branch * Update status check if job failed * Update status check if job failed * Manual order transaction refund (#4774) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * fixing flaky tests (#4772) (#4778) * Show all transaction in manual refund view (#4779) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * Show all transactions * Add changeset * Update tests * Extract messages * Fix typo * Improve tooltip * [E2E] [QA] Optimizing playwright setup and playwright.config.ts files (#4741) * adding condition to not create json file if it does exist * adding cache * adding cache * updating yml files * fixing GH action * fixing flaky test * adding randomization to tests execution * reverting * fixing flaky tests * updating other gh workflows consisting of pw test run * Fix version * Fix checkout * [E2E] Tests for product types (#4757) * initial commit with changelog * add test for update product type * add test to delete several product types * add test to remove product type with asigned product * fix numering and assertion after removing types * typo * update test data * add assertions * remove stripe and emails plugins app replacement message (#4777) * switch version to 3.19 * Fix submit results * Fix update check * Fix update check * Fix update check * Fix script * Fix status * test trigger run tests on release job * last test * last test * [E2E] Use dummy app in delete app test (#4789) * replace app * update test data * fixing flaky gift cards tests (#4785) * Fix workflow name * Fix names * Fix names * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for higher versions - playwright * Delete test workflow * Add changeset * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/prepare-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * use jq, don't use string interpolation * Check if still works after review changes * Fix crete check * Fix crete check * Fix crete check * Remove leftovers * Fix head sha * Fix head sha * Fix head sha * Fix head sha * cleanup after tests * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * tests if works after review changes * tests if works after review changes * Remove testing workflow * Update .github/actions/checks/update-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/run-tests-on-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/actions/prepare-api-variables/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * merge deploy and prepare release workflows --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
karola312
added a commit
that referenced
this pull request
May 7, 2024
* Test PR - running playwright tests after deployment * Test PR - running playwright tests after deployment * Rerun job * open draft PR * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Check if PR exist * Check if PR exist * Check if PR exist * Check if PR exist * restore data from snapshot * Allow user without app permission access apps view (#4738) * Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests * [E2E] Fixing flaky e2e tests (#4751) * adding extra assertion to translation tests * updating assertion in attribute tests * modifying assertions for gift card tests * [E2E] Fixing another batch of flaky tests (#4756) * updating tests for extra assertions and adding skip to App test * updating tests for extra assertions * updating tests for extra assertions and temporarily commenting not working assertions * adding PW test for readonly Apps access (#4755) * [QA] Correcting e2e test case ids (#4764) * correcting test case ids * fixing flaky test * Update .changeset/serious-books-wave.md Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> --------- Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> * New github action for gathering metrics (#4762) * New github action for metrics gathering * metrics file name containing date * search query repo update * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> * Update repo-metrics.yml * Update repo-metrics.yml * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> --------- Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Gathering pull requests metrics (#4766) * fix workflow dispatch trigger * fix workflow dispatch trigger * metrics for pr * removed date from file name * on push added * wip * date in issue name, workflow dispatch trigger * Create long-keys-compare.md * add siteSettings basic test (#4759) * Remove babel (#4711) * Remove babel * Add changeset * Fix showing empty tooltip when no content by bumping macaw-ui to newest (#4771) * Bump macaw * Add changeset * [E2E] Tests for page types (#4765) * add changeset * add test data * add tests and update data-test-id * code review fixes * spaces * adding test for permission groups (#4758) * fixing flaky tests (#4772) * Send tests results when running manually (#4737) * Send tests results when running manually * Send tests results when running manually * Send tests results when running manually * Check if it is working * Fix init testmo * Fix submit threads * Fix working directory when sending results to testmo * Add name and tag * Add name and tag * Fix run name * Add reports when tests run by cron * Fix messages skip ci * Fix messages [skip ci] * Sending playwright tests results to slack and testmo * Update .github/workflows/tests-nightly.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * changes fter review * fix changeset --------- Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Fix version * Run tests * Run tests on correct branch * Update status check if job failed * Update status check if job failed * Manual order transaction refund (#4774) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * fixing flaky tests (#4772) (#4778) * Show all transaction in manual refund view (#4779) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * Show all transactions * Add changeset * Update tests * Extract messages * Fix typo * Improve tooltip * [E2E] [QA] Optimizing playwright setup and playwright.config.ts files (#4741) * adding condition to not create json file if it does exist * adding cache * adding cache * updating yml files * fixing GH action * fixing flaky test * adding randomization to tests execution * reverting * fixing flaky tests * updating other gh workflows consisting of pw test run * Fix version * Fix checkout * [E2E] Tests for product types (#4757) * initial commit with changelog * add test for update product type * add test to delete several product types * add test to remove product type with asigned product * fix numering and assertion after removing types * typo * update test data * add assertions * remove stripe and emails plugins app replacement message (#4777) * switch version to 3.19 * Fix submit results * Fix update check * Fix update check * Fix update check * Fix script * Fix status * test trigger run tests on release job * last test * last test * [E2E] Use dummy app in delete app test (#4789) * replace app * update test data * fixing flaky gift cards tests (#4785) * Fix workflow name * Fix names * Fix names * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for higher versions - playwright * Delete test workflow * Add changeset * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/prepare-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * use jq, don't use string interpolation * Check if still works after review changes * Fix crete check * Fix crete check * Fix crete check * Remove leftovers * Fix head sha * Fix head sha * Fix head sha * Fix head sha * cleanup after tests * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * tests if works after review changes * tests if works after review changes * Remove testing workflow * Update .github/actions/checks/update-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/run-tests-on-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/actions/prepare-api-variables/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * merge deploy and prepare release workflows --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
karola312
added a commit
that referenced
this pull request
May 8, 2024
* Test PR - running playwright tests after deployment * Test PR - running playwright tests after deployment * Rerun job * open draft PR * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Check if PR exist * Check if PR exist * Check if PR exist * Check if PR exist * restore data from snapshot * Allow user without app permission access apps view (#4738) * Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests * [E2E] Fixing flaky e2e tests (#4751) * adding extra assertion to translation tests * updating assertion in attribute tests * modifying assertions for gift card tests * [E2E] Fixing another batch of flaky tests (#4756) * updating tests for extra assertions and adding skip to App test * updating tests for extra assertions * updating tests for extra assertions and temporarily commenting not working assertions * adding PW test for readonly Apps access (#4755) * [QA] Correcting e2e test case ids (#4764) * correcting test case ids * fixing flaky test * Update .changeset/serious-books-wave.md --------- * New github action for gathering metrics (#4762) * New github action for metrics gathering * metrics file name containing date * search query repo update * Update .github/workflows/repo-metrics.yml * Update repo-metrics.yml * Update repo-metrics.yml * Update .github/workflows/repo-metrics.yml --------- * Gathering pull requests metrics (#4766) * fix workflow dispatch trigger * fix workflow dispatch trigger * metrics for pr * removed date from file name * on push added * wip * date in issue name, workflow dispatch trigger * Create long-keys-compare.md * add siteSettings basic test (#4759) * Remove babel (#4711) * Remove babel * Add changeset * Fix showing empty tooltip when no content by bumping macaw-ui to newest (#4771) * Bump macaw * Add changeset * [E2E] Tests for page types (#4765) * add changeset * add test data * add tests and update data-test-id * code review fixes * spaces * adding test for permission groups (#4758) * fixing flaky tests (#4772) * Send tests results when running manually (#4737) * Send tests results when running manually * Send tests results when running manually * Send tests results when running manually * Check if it is working * Fix init testmo * Fix submit threads * Fix working directory when sending results to testmo * Add name and tag * Add name and tag * Fix run name * Add reports when tests run by cron * Fix messages skip ci * Fix messages [skip ci] * Sending playwright tests results to slack and testmo * Update .github/workflows/tests-nightly.yml * changes fter review * fix changeset --------- * Fix version * Run tests * Run tests on correct branch * Update status check if job failed * Update status check if job failed * Manual order transaction refund (#4774) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * fixing flaky tests (#4772) (#4778) * Show all transaction in manual refund view (#4779) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * Show all transactions * Add changeset * Update tests * Extract messages * Fix typo * Improve tooltip * [E2E] [QA] Optimizing playwright setup and playwright.config.ts files (#4741) * adding condition to not create json file if it does exist * adding cache * adding cache * updating yml files * fixing GH action * fixing flaky test * adding randomization to tests execution * reverting * fixing flaky tests * updating other gh workflows consisting of pw test run * Fix version * Fix checkout * [E2E] Tests for product types (#4757) * initial commit with changelog * add test for update product type * add test to delete several product types * add test to remove product type with asigned product * fix numering and assertion after removing types * typo * update test data * add assertions * remove stripe and emails plugins app replacement message (#4777) * switch version to 3.19 * Fix submit results * Fix update check * Fix update check * Fix update check * Fix script * Fix status * test trigger run tests on release job * last test * last test * [E2E] Use dummy app in delete app test (#4789) * replace app * update test data * fixing flaky gift cards tests (#4785) * Fix workflow name * Fix names * Fix names * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for higher versions - playwright * Delete test workflow * Add changeset * Update .github/actions/checks/create-pull-request-check/action.yml * Update .github/workflows/prepare-release.yml * use jq, don't use string interpolation * Check if still works after review changes * Fix crete check * Fix crete check * Fix crete check * Remove leftovers * Fix head sha * Fix head sha * Fix head sha * Fix head sha * cleanup after tests * Update .github/actions/checks/create-pull-request-check/action.yml * tests if works after review changes * tests if works after review changes * Remove testing workflow * Update .github/actions/checks/update-pull-request-check/action.yml * Update .github/workflows/run-tests-on-release.yml * Update .github/actions/prepare-api-variables/action.yml * merge deploy and prepare release workflows --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
karola312
added a commit
that referenced
this pull request
May 9, 2024
* Test PR - running playwright tests after deployment * Test PR - running playwright tests after deployment * Rerun job * open draft PR * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Check if PR exist * Check if PR exist * Check if PR exist * Check if PR exist * restore data from snapshot * Allow user without app permission access apps view (#4738) * Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests * [E2E] Fixing flaky e2e tests (#4751) * adding extra assertion to translation tests * updating assertion in attribute tests * modifying assertions for gift card tests * [E2E] Fixing another batch of flaky tests (#4756) * updating tests for extra assertions and adding skip to App test * updating tests for extra assertions * updating tests for extra assertions and temporarily commenting not working assertions * adding PW test for readonly Apps access (#4755) * [QA] Correcting e2e test case ids (#4764) * correcting test case ids * fixing flaky test * Update .changeset/serious-books-wave.md Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> --------- Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> * New github action for gathering metrics (#4762) * New github action for metrics gathering * metrics file name containing date * search query repo update * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> * Update repo-metrics.yml * Update repo-metrics.yml * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> --------- Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Gathering pull requests metrics (#4766) * fix workflow dispatch trigger * fix workflow dispatch trigger * metrics for pr * removed date from file name * on push added * wip * date in issue name, workflow dispatch trigger * Create long-keys-compare.md * add siteSettings basic test (#4759) * Remove babel (#4711) * Remove babel * Add changeset * Fix showing empty tooltip when no content by bumping macaw-ui to newest (#4771) * Bump macaw * Add changeset * [E2E] Tests for page types (#4765) * add changeset * add test data * add tests and update data-test-id * code review fixes * spaces * adding test for permission groups (#4758) * fixing flaky tests (#4772) * Send tests results when running manually (#4737) * Send tests results when running manually * Send tests results when running manually * Send tests results when running manually * Check if it is working * Fix init testmo * Fix submit threads * Fix working directory when sending results to testmo * Add name and tag * Add name and tag * Fix run name * Add reports when tests run by cron * Fix messages skip ci * Fix messages [skip ci] * Sending playwright tests results to slack and testmo * Update .github/workflows/tests-nightly.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * changes fter review * fix changeset --------- Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Fix version * Run tests * Run tests on correct branch * Update status check if job failed * Update status check if job failed * Manual order transaction refund (#4774) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * fixing flaky tests (#4772) (#4778) * Show all transaction in manual refund view (#4779) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * Show all transactions * Add changeset * Update tests * Extract messages * Fix typo * Improve tooltip * [E2E] [QA] Optimizing playwright setup and playwright.config.ts files (#4741) * adding condition to not create json file if it does exist * adding cache * adding cache * updating yml files * fixing GH action * fixing flaky test * adding randomization to tests execution * reverting * fixing flaky tests * updating other gh workflows consisting of pw test run * Fix version * Fix checkout * [E2E] Tests for product types (#4757) * initial commit with changelog * add test for update product type * add test to delete several product types * add test to remove product type with asigned product * fix numering and assertion after removing types * typo * update test data * add assertions * remove stripe and emails plugins app replacement message (#4777) * switch version to 3.19 * Fix submit results * Fix update check * Fix update check * Fix update check * Fix script * Fix status * test trigger run tests on release job * last test * last test * [E2E] Use dummy app in delete app test (#4789) * replace app * update test data * fixing flaky gift cards tests (#4785) * Fix workflow name * Fix names * Fix names * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for higher versions - playwright * Delete test workflow * Add changeset * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/prepare-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * use jq, don't use string interpolation * Check if still works after review changes * Fix crete check * Fix crete check * Fix crete check * Remove leftovers * Fix head sha * Fix head sha * Fix head sha * Fix head sha * cleanup after tests * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * tests if works after review changes * tests if works after review changes * Remove testing workflow * Update .github/actions/checks/update-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/run-tests-on-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/actions/prepare-api-variables/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * merge deploy and prepare release workflows --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
karola312
added a commit
that referenced
this pull request
May 27, 2024
* Run automation tests on release (#4775) * Test PR - running playwright tests after deployment * Test PR - running playwright tests after deployment * Rerun job * open draft PR * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Add check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Update check * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Move create check to seperate file * Check if PR exist * Check if PR exist * Check if PR exist * Check if PR exist * restore data from snapshot * Allow user without app permission access apps view (#4738) * Allow user without app permission access apps view * Use css subgrid instead of multiple map loops * Add protection to queries and mutation that use App fragments * Allow user to see manage app view * Refactor app permission check to hook * Protect routes * shouldShowInstalledApps * Refactor AppListPage, write test for loading, empty state with checking manage_app perm * Change manage button label depend on manage_apps * Improve typing * Extract messages * ButtonWithTooltip * Refactor HeaderOptions, block action when no manage_apps * Improve buttons * Add changset * Adjust singlePermission tests * Remove required hasManagedAppsPermission when default * Improve action icons * Improve naming and refactor AppListCardInstallButton * Improve changset * Improve tests * [E2E] Fixing flaky e2e tests (#4751) * adding extra assertion to translation tests * updating assertion in attribute tests * modifying assertions for gift card tests * [E2E] Fixing another batch of flaky tests (#4756) * updating tests for extra assertions and adding skip to App test * updating tests for extra assertions * updating tests for extra assertions and temporarily commenting not working assertions * adding PW test for readonly Apps access (#4755) * [QA] Correcting e2e test case ids (#4764) * correcting test case ids * fixing flaky test * Update .changeset/serious-books-wave.md Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> --------- Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> * New github action for gathering metrics (#4762) * New github action for metrics gathering * metrics file name containing date * search query repo update * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> * Update repo-metrics.yml * Update repo-metrics.yml * Update .github/workflows/repo-metrics.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> --------- Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Gathering pull requests metrics (#4766) * fix workflow dispatch trigger * fix workflow dispatch trigger * metrics for pr * removed date from file name * on push added * wip * date in issue name, workflow dispatch trigger * Create long-keys-compare.md * add siteSettings basic test (#4759) * Remove babel (#4711) * Remove babel * Add changeset * Fix showing empty tooltip when no content by bumping macaw-ui to newest (#4771) * Bump macaw * Add changeset * [E2E] Tests for page types (#4765) * add changeset * add test data * add tests and update data-test-id * code review fixes * spaces * adding test for permission groups (#4758) * fixing flaky tests (#4772) * Send tests results when running manually (#4737) * Send tests results when running manually * Send tests results when running manually * Send tests results when running manually * Check if it is working * Fix init testmo * Fix submit threads * Fix working directory when sending results to testmo * Add name and tag * Add name and tag * Fix run name * Add reports when tests run by cron * Fix messages skip ci * Fix messages [skip ci] * Sending playwright tests results to slack and testmo * Update .github/workflows/tests-nightly.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * changes fter review * fix changeset --------- Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Fix version * Run tests * Run tests on correct branch * Update status check if job failed * Update status check if job failed * Manual order transaction refund (#4774) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * fixing flaky tests (#4772) (#4778) * Show all transaction in manual refund view (#4779) * Order manual transaction view init * Connect RHF * Add sending mutation * Refactor, add intl, fix form validation * extract messages * Add changeset * Refactor transactions tiles * Improve loading and disable state, fix radio group control * Hadle no transactions * Write tests * extract messages * Refactor fragments * Move mutation to form component * Fix test * Show all transactions * Add changeset * Update tests * Extract messages * Fix typo * Improve tooltip * [E2E] [QA] Optimizing playwright setup and playwright.config.ts files (#4741) * adding condition to not create json file if it does exist * adding cache * adding cache * updating yml files * fixing GH action * fixing flaky test * adding randomization to tests execution * reverting * fixing flaky tests * updating other gh workflows consisting of pw test run * Fix version * Fix checkout * [E2E] Tests for product types (#4757) * initial commit with changelog * add test for update product type * add test to delete several product types * add test to remove product type with asigned product * fix numering and assertion after removing types * typo * update test data * add assertions * remove stripe and emails plugins app replacement message (#4777) * switch version to 3.19 * Fix submit results * Fix update check * Fix update check * Fix update check * Fix script * Fix status * test trigger run tests on release job * last test * last test * [E2E] Use dummy app in delete app test (#4789) * replace app * update test data * fixing flaky gift cards tests (#4785) * Fix workflow name * Fix names * Fix names * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * do not run cypress if higher version * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for lower versions run only cypress * test for higher versions - playwright * Delete test workflow * Add changeset * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/prepare-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * use jq, don't use string interpolation * Check if still works after review changes * Fix crete check * Fix crete check * Fix crete check * Remove leftovers * Fix head sha * Fix head sha * Fix head sha * Fix head sha * cleanup after tests * Update .github/actions/checks/create-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * tests if works after review changes * tests if works after review changes * Remove testing workflow * Update .github/actions/checks/update-pull-request-check/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/workflows/run-tests-on-release.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * Update .github/actions/prepare-api-variables/action.yml Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> * merge deploy and prepare release workflows --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io> * Run cypress tests for releases on 3.18 * Run cypress tests for releases on 3.18 * Run cypress tests for releases on 3.18 * Run cypress tests for releases on 3.18 * fix testmo id * fix testmo id * remove test workflow * Fix statuses --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Renata <renata.gajzlerowicz@gmail.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Mikolaj Stempniewicz <mikolaj@stempniewicz.net> Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com> Co-authored-by: M.Graczyk <michalina.graczyk@saleor.io> Co-authored-by: Anna Szczęch <30683248+szczecha@users.noreply.github.com> Co-authored-by: Lukasz Ostrowski <lukasz.ostrowski@saleor.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR allows all users access to APPS tab. Since all users will have access there we moved checking required permission per app.
Users without
MANAGE_APPSwill be able to:Manage apptoApp settings)Users without
MANAGE_APPSwill not be able to:Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description