Timeline events improvements for displaying user and app details #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63720d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
force-pushed
the
MERX-276-fix-avatar-initials
branch
from
83b1c3c to
8177c39
Compare
Cloud11PL
changed the title
poulch
reviewed
Apr 15, 2024
poulch
previously approved these changes
Apr 15, 2024
poulch
previously approved these changes
Apr 15, 2024
poulch
previously approved these changes
Apr 18, 2024
poulch
previously approved these changes
Apr 18, 2024
Cloud11PL
force-pushed
the
MERX-276-fix-avatar-initials
branch
from
bc300de to
b376105
Compare
Cloud11PL
force-pushed
the
MERX-276-fix-avatar-initials
branch
from
6885f28 to
9652a06
Compare
Cloud11PL
force-pushed
the
MERX-276-fix-avatar-initials
branch
from
9652a06 to
973d88d
Compare
poulch
approved these changes
Apr 23, 2024
| ); | ||
|
|
||
| // Assert | ||
| const avatar = container.querySelector("img"); |
There was a problem hiding this comment.
suggestion: using container is not recommended, you could query this img by role or by tag name easily
Droniu
approved these changes
Apr 23, 2024
poulch
added a commit
that referenced
this pull request
Apr 23, 2024
* fix avatar display for history component * changeset * fix app avatars; improve date format consistency * fix fixtures * improve changeset message * cr fixes * add timeline note tests * fix tests * AAA * add comments in note test * trigger * migrate to strict * trigger --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
Description