Support channel setting: AutomaticallyCompleteFullyPaidCheckouts #5199
Conversation
🦋 Changeset detectedLatest commit: 52cdbd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| values={{ | ||
| link: ( | ||
| <Link | ||
| href="https://docs.saleor.io/developer/payments/transactions#automatic-checkout-completion" |
There was a problem hiding this comment.
question: what about putting this link in src/links.ts?
There was a problem hiding this comment.
Good idea. I suggest you add ESLint rule that will suggest such change
| @@ -212,6 +216,13 @@ export const ChannelForm: React.FC<ChannelFormProps> = ({ | |||
| hasError={!!formErrors.defaultTransactionFlowStrategy} | |||
| disabled={disabled} | |||
| /> | |||
| <Box /> | |||
There was a problem hiding this comment.
questtion: do we need this empty box?
There was a problem hiding this comment.
container is written incorrectly, so Box seems to be used to push the component to the new line. This should be refactored but its out of the scope of my changes
|
|
||
| const handleAutomaticallyCompleteCheckoutsChange = () => { | ||
| set({ | ||
| automaticallyCompleteCheckouts: !data.automaticallyCompleteCheckouts, |
There was a problem hiding this comment.
Becasue its a checkbox, so it inverts data (false → true, true → false)
The handler doesnt receive the change, it uses current data to flip the state
Screen.Recording.2024-10-04.at.10.13.52.mov |
|
|
|
|
|
This pull request is stale because it has been open 14 days with no activity. |
|
This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team |
* Regenerate graphql types * Fetch new field from api, stub display * add setting to mutation * ui * better messages * changeset * fix fixtures * Include new field in channel creation * add new event mapping and extract messages
Waiting for API to be released everywhere in Saleor Cloud
What type of PR is this?
Related Issues or Documents
saleor/saleor-docs#1334
saleor/saleor#16782
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description