Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update schema decimal #695

Merged
merged 3 commits into from
Sep 9, 2020
Merged

update schema decimal #695

merged 3 commits into from
Sep 9, 2020

Conversation

AlicjaSzu
Copy link
Contributor

@AlicjaSzu AlicjaSzu commented Sep 7, 2020 •
edited
Loading

I want to merge this change because...

**PR intended to be tested with API branch: update-default-decimal-places

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://update-default-decimal-places.staging.saleor.rocks/graphql/

@AlicjaSzu AlicjaSzu self-assigned this Sep 7, 2020
@github-actions github-actions bot temporarily deployed to feature-update-default-decimal-places September 7, 2020 10:50 Inactive
@patrys
Copy link
Member

patrys commented Sep 7, 2020

Task linked: SALEOR-1000 Update schema

@AlicjaSzu AlicjaSzu changed the title update default decimal places update schema decimal Sep 7, 2020
@github-actions github-actions bot temporarily deployed to feature-update-default-decimal-places September 7, 2020 11:07 Inactive
@github-actions github-actions bot temporarily deployed to feature-update-default-decimal-places September 9, 2020 09:34 Inactive
@maarcingebala maarcingebala merged commit 14da39e into master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

@dominik-zeglen dominik-zeglen Awaiting requested review from dominik-zeglen

Assignees

@AlicjaSzu AlicjaSzu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlicjaSzu @patrys @krzysztofwolski @orzechdev @maarcingebala