Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned rich text draft controls #725

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Sep 22, 2020

I want to merge this change because...

PR intended to be tested with API branch:

Screenshots

before:
Zrzut ekranu 2020-09-22 o 17 09 42

after:
Zrzut ekranu 2020-09-22 o 17 09 50

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-misaligned-rich-text-controls September 22, 2020 15:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-misaligned-rich-text-controls September 22, 2020 15:06 Inactive
@github-actions github-actions bot temporarily deployed to fix-misaligned-rich-text-controls September 22, 2020 15:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-misaligned-rich-text-controls September 22, 2020 15:10 Inactive
@patrys
Copy link
Member

patrys commented Sep 22, 2020

@orzechdev orzechdev marked this pull request as ready for review September 22, 2020 15:24
@krzysztofwolski
Copy link
Member

Tested on storybook, LGTM

@orzechdev orzechdev force-pushed the fix/misaligned-rich-text-controls branch from dd6e145 to c43014e Compare September 23, 2020 15:59
@github-actions github-actions bot temporarily deployed to fix-misaligned-rich-text-controls September 23, 2020 16:00 Inactive
@orzechdev orzechdev merged commit eed93fc into master Sep 23, 2020
@orzechdev orzechdev deleted the fix/misaligned-rich-text-controls branch September 23, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants