Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manage product types and attributes permission #768

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Oct 15, 2020

I want to merge this change because... it updates permission list and restricts access to product types and attributes pages based on the new permission.

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to refactor-product-permissions October 15, 2020 11:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook refactor-product-permissions October 15, 2020 11:39 Inactive
@github-actions github-actions bot temporarily deployed to refactor-product-permissions October 15, 2020 11:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook refactor-product-permissions October 15, 2020 11:54 Inactive
@patrys
Copy link
Member

patrys commented Oct 15, 2020

Task linked: SALEOR-1284 Update permissions list

@orzechdev orzechdev force-pushed the refactor/product-permissions branch from b2c1473 to e0a1d11 Compare October 15, 2020 12:44
@github-actions github-actions bot temporarily deployed to refactor-product-permissions October 15, 2020 12:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook refactor-product-permissions October 15, 2020 12:44 Inactive
@orzechdev orzechdev changed the title Update product permissions Add manage product types and attributes permission Oct 15, 2020
@github-actions github-actions bot temporarily deployed to refactor-product-permissions October 15, 2020 13:24 Inactive
@orzechdev orzechdev marked this pull request as ready for review October 15, 2020 13:30
@dominik-zeglen dominik-zeglen merged commit de31431 into master Oct 16, 2020
@dominik-zeglen dominik-zeglen deleted the refactor/product-permissions branch October 16, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants