Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for fulfilling order when allocated quantity equals total quantity #788

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Fix for fulfilling order when allocated quantity equals total quantity #788

merged 6 commits into from
Nov 3, 2020

Conversation

GrzegorzDerdak
Copy link
Contributor

@GrzegorzDerdak GrzegorzDerdak commented Oct 22, 2020 •
edited
Loading

Fix for fulfilling order when product quantity is 1 or when product quantity equals the number of allocated resources.

PR intended to be tested with API branch: saleor/saleor#6333

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@GrzegorzDerdak GrzegorzDerdak added the in progress This PR is still in development label Oct 22, 2020
@GrzegorzDerdak GrzegorzDerdak self-assigned this Oct 22, 2020
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 22, 2020 10:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 22, 2020 10:01 Inactive
@GrzegorzDerdak GrzegorzDerdak marked this pull request as ready for review October 22, 2020 10:03
@GrzegorzDerdak GrzegorzDerdak requested a review from a team October 22, 2020 10:03
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 22, 2020 10:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 22, 2020 10:03 Inactive
@GrzegorzDerdak
Copy link
Contributor Author

Task related: Cannot fulfill order when product quantity is 1
Issue related: saleor/saleor#6136

@GrzegorzDerdak GrzegorzDerdak removed the in progress This PR is still in development label Oct 22, 2020
@NyanKiyoshi NyanKiyoshi requested review from a team and removed request for a team October 22, 2020 10:27
@patrys
Copy link
Member

patrys commented Oct 22, 2020

Task linked: SALEOR-1403 Cannot fulfill order when product quantity is 1

@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:08 Inactive
@GrzegorzDerdak GrzegorzDerdak force-pushed the SALEOR-1403-cannot-fulfill-order-when-product-quantity-is-one branch from 808e010 to 9337bdf Compare October 23, 2020 11:18
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:18 Inactive
@GrzegorzDerdak GrzegorzDerdak changed the title Fix for fulfilling order when product quantity is 1 Fix for fulfilling order when allocated quantity equals total quantity Oct 23, 2020
@GrzegorzDerdak GrzegorzDerdak force-pushed the SALEOR-1403-cannot-fulfill-order-when-product-quantity-is-one branch from 9337bdf to 9036294 Compare October 23, 2020 11:21
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 23, 2020 11:21 Inactive
@dominik-zeglen dominik-zeglen added the in progress This PR is still in development label Oct 23, 2020
@GrzegorzDerdak GrzegorzDerdak mentioned this pull request Oct 28, 2020
Merged
11 tasks
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 28, 2020 11:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 28, 2020 11:43 Inactive
@GrzegorzDerdak GrzegorzDerdak removed the in progress This PR is still in development label Oct 28, 2020
@GrzegorzDerdak GrzegorzDerdak requested a review from a team October 28, 2020 12:33
@GrzegorzDerdak GrzegorzDerdak force-pushed the SALEOR-1403-cannot-fulfill-order-when-product-quantity-is-one branch from f80f6e4 to e14b144 Compare October 30, 2020 13:19
@github-actions github-actions bot temporarily deployed to saleor-1403-cannot-fulfill-order-when-product-quantity-is-one October 30, 2020 13:19 Inactive
@dominik-zeglen
Copy link
Contributor

Quick explanation:
allocationToFulfill

Red diamonds are units allocated to other orders, blue ones are for now fulfilled order.

@dominik-zeglen dominik-zeglen merged commit bf88825 into master Nov 3, 2020
@dominik-zeglen dominik-zeglen deleted the SALEOR-1403-cannot-fulfill-order-when-product-quantity-is-one branch November 3, 2020 11:15
@PirunSeng
Copy link

Hi There! The issue seems to be fixed :) May I know if it is already deployed to the demo?

@maarcingebala
Copy link
Member

Hey, it was released as part of 2.11 release but the demo wasn't yet updated.

@PirunSeng
Copy link

Thanks @maarcingebala , hope it'll be updated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@dominik-zeglen dominik-zeglen dominik-zeglen approved these changes

@mlamperski mlamperski Awaiting requested review from mlamperski

@maarcingebala maarcingebala Awaiting requested review from maarcingebala

Assignees

@GrzegorzDerdak GrzegorzDerdak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GrzegorzDerdak @patrys @dominik-zeglen @PirunSeng @maarcingebala @orzechdev