Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zip code range #862

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds zip core range editor.

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-11-25 at 17 39 27

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@dominik-zeglen dominik-zeglen marked this pull request as draft November 25, 2020 16:58
@patrys
Copy link
Member

patrys commented Nov 25, 2020

Task linked: SALEOR-1749 Zip code range creation modal

@dominik-zeglen dominik-zeglen marked this pull request as ready for review November 26, 2020 15:55
@dominik-zeglen dominik-zeglen force-pushed the SALEOR-1749-add-zip-code-range branch from 9d7abc4 to 59d591e Compare November 27, 2020 14:46
@github-actions github-actions bot temporarily deployed to saleor-1749-add-zip-code-range November 27, 2020 14:46 Inactive
@github-actions github-actions bot had a problem deploying to storybook saleor-1749-add-zip-code-range November 27, 2020 14:46 Failure
@dominik-zeglen dominik-zeglen mentioned this pull request Nov 27, 2020
8 tasks
@dominik-zeglen dominik-zeglen merged commit 8891762 into feature/exclude-products-and-zip-codes Nov 30, 2020
@dominik-zeglen dominik-zeglen deleted the SALEOR-1749-add-zip-code-range branch November 30, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants