Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zip code exclusion #877

Merged
merged 22 commits into from
Dec 1, 2020
Merged

Add zip code exclusion #877

merged 22 commits into from
Dec 1, 2020

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Nov 30, 2020 •
edited
Loading

I want to merge this change because it allows certain zip code ranges to be excluded from shipping method.

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-11-25 at 16 28 04

Screenshot 2020-11-25 at 17 39 27

Screenshot 2020-11-27 at 16 10 30

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks//graphql/

@krzysztofwolski krzysztofwolski mentioned this pull request Nov 30, 2020
Merged
8 tasks
@dominik-zeglen dominik-zeglen force-pushed the feature/exclude-products-and-zip-codes branch from de10abf to d5cef24 Compare November 30, 2020 14:11
@dominik-zeglen dominik-zeglen marked this pull request as ready for review November 30, 2020 14:11
@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes November 30, 2020 14:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes November 30, 2020 14:12 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request introduces 1 alert when merging d5cef24 into 07f8f4b - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes November 30, 2020 14:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes November 30, 2020 14:36 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request introduces 1 alert when merging 86e50d0 into 07f8f4b - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@maarcingebala maarcingebala mentioned this pull request Nov 30, 2020
Merged
11 tasks
@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes November 30, 2020 15:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes November 30, 2020 15:22 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request introduces 1 alert when merging a93a68d into 07f8f4b - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@krzysztofwolski
Copy link
Member

Passing Issue for QA @mlamperski

@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes December 1, 2020 10:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes December 1, 2020 10:02 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 1 alert when merging 1406919 into 07f8f4b - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes December 1, 2020 10:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes December 1, 2020 10:53 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 1 alert when merging d77ae4f into 07f8f4b - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes December 1, 2020 11:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes December 1, 2020 11:44 Inactive
dominik-zeglen and others added 18 commits December 1, 2020 14:33
@dominik-zeglen @krzysztofwolski
Add zip codes section (#861)
039aa16 
* Add zip code listing

* Add list wrapping

* Update snapshots

* Set up API data

* Fix lgtm warning

* Update snapshots

* Run Actions on all PR

* Checks on PR

* Test envs on PR

* Cleanup action on PR

* Update messages

Co-authored-by: Krzysztof Wolski <krzysztof.k.wolski@gmail.com>
@dominik-zeglen
Add zip code range dialog
6f61d68
@dominik-zeglen
Fix path management
61ee6bd
@dominik-zeglen
Use query params to handle modal actions
f749853
@dominik-zeglen
Allow zip codes to be assigned to shipping method
4fecd21
@dominik-zeglen
Make params optional
4473c16
@dominik-zeglen
Fix types
694ee18
@dominik-zeglen
Add zip code deletion (#871)
52159ca 
* Add zip code range dialog

* Fix path management

* Use query params to handle modal actions

* Allow zip codes to be assigned to shipping method

* Make params optional

* Fix types

* Clean up urls

* Add zip code range delete action

* Update snapshots and messages
@dominik-zeglen
Update testing and changelog
7d61296
@dominik-zeglen
Update schema
ff76719
@dominik-zeglen
Simplify code
0ceb332
@dominik-zeglen
Refresh zip code list after assigning them
391d314
@dominik-zeglen
Update view after zip code deletion
eb38a5f
@dominik-zeglen
Update types and snapshots
0b9bfd9
@dominik-zeglen
Update snapshots
c5246db
@tomaszszymanski129 @dominik-zeglen
Fix error message, checkbox default value (#880)
b2fe1f0 
* Fix error message, checkbox default value

* Update snapshots
@dominik-zeglen
Use price instead of weight variant
50ddf99
@dominik-zeglen
Update schema and types
ccdf554
@dominik-zeglen dominik-zeglen force-pushed the feature/exclude-products-and-zip-codes branch from df4a039 to ccdf554 Compare December 1, 2020 13:45
@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes December 1, 2020 13:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-exclude-products-and-zip-codes December 1, 2020 13:45 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 1 alert when merging ccdf554 into eb351b3 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@github-actions github-actions bot temporarily deployed to feature-exclude-products-and-zip-codes December 1, 2020 14:32 Inactive
@patrys
Copy link
Member

patrys commented Dec 1, 2020

Task linked: SALEOR-1798 [BUG] Price rate changes to weight rate

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 1 alert when merging 6ab8dfa into eb351b3 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@krzysztofwolski krzysztofwolski merged commit e55805a into master Dec 1, 2020
@krzysztofwolski krzysztofwolski deleted the feature/exclude-products-and-zip-codes branch December 1, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlicjaSzu AlicjaSzu AlicjaSzu approved these changes

@orzechdev orzechdev orzechdev approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

@mlamperski mlamperski Awaiting requested review from mlamperski

Assignees
No one assigned
Labels
Feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dominik-zeglen @krzysztofwolski @patrys @orzechdev @AlicjaSzu @tomaszszymanski129