Fix Chrome 87 fieldset rendering bug #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-zeglen
requested review from
krzysztofwolski,
orzechdev,
AlicjaSzu and
bmigirl
|
Task linked: SALEOR-1751 Investigate rendering in chrome 87 |
|
I thought it's the fault of a beta version of Chrome but now I'm on a stable version and still getting these issues constantly. Glad it will be resolved 🙏 |
github-actions
bot
temporarily deployed
to
storybook saleor-1751-chrome-bugs
github-actions
bot
temporarily deployed
to
storybook saleor-1751-chrome-bugs
orzechdev
suggested changes
Dec 2, 2020
src/theme.ts
Outdated
| @@ -73,7 +229,7 @@ export default (colors: IThemeColors): Theme => | |||
| borderRadius: 8, | |||
| borderStyle: "solid", | |||
| borderWidth: 1, | |||
| overflow: "visible" | |||
| overflow: "hidden" | |||
There was a problem hiding this comment.
Probably this is the cause of input issue - without this change, it displayed popup also outside of the card:
There was a problem hiding this comment.
Aw damn this is part of debug code 🙄
orzechdev
approved these changes
Dec 2, 2020
bmigirl
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it happened:
... and now it doesn't.
Ref https://www.drupal.org/project/drupal/issues/3183425
PR intended to be tested with API branch: master
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/