Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return form quick fixes #952

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

bmigirl
Copy link
Contributor

@bmigirl bmigirl commented Jan 20, 2021

I want to merge this change because it fixes return form:

  • not redirecting after successful return/refund
  • refund button not being disabled when no products selected
  • refund in form data being set to true even when captured total at order was 0
  • also made a class of parser

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Magdalena Markusik added 2 commits January 20, 2021 11:27
@github-actions github-actions bot temporarily deployed to super-duper-urgent-return-fixes January 20, 2021 10:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook super-duper-urgent-return-fixes January 20, 2021 10:33 Inactive
@bmigirl bmigirl merged commit 652d0c6 into feature/order-reissue Jan 20, 2021
@bmigirl bmigirl deleted the super-duper-urgent-return-fixes branch January 20, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants