Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Product page crashes with more than two variant attributes #514

Closed
maarcingebala opened this issue Nov 19, 2019 · 0 comments · Fixed by #550
Closed

Product page crashes with more than two variant attributes #514

maarcingebala opened this issue Nov 19, 2019 · 0 comments · Fixed by #550
Assignees
Labels
bug Something isn't working Feature request New feature or request

Comments

@maarcingebala
Copy link
Member

We shuold support rendering products with more than two variant attribtues. E.g this is a valid Saleor product with three variant attributes:

Screenshot 2019-11-19 at 12 23 31

In the storefront it should be rendered as three separate dropdowns, since you need to specify each of those attributes to define a variant that you want to add to the cart.

The problem is that in the ProductDescription component we assume that there may be at most two attribute pickers:

https://github.com/mirumee/saleor-storefront/blob/a98138786e9c9560d8f76cd40a0a45f66ca21d7a/src/components/ProductDescription/index.tsx#L24-L25

The design for the new product page supporting more than two pickers:
Screenshot 2019-11-19 at 12 30 31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants