This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 672
Support multiple product variant attributes #550
Merged
orzechdev
merged 33 commits into
master
from
fix/unsupported_multiple_product_variant_attributes
Jan 13, 2020
Merged
Support multiple product variant attributes #550
orzechdev
merged 33 commits into
master
from
fix/unsupported_multiple_product_variant_attributes
Jan 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwm0
reviewed
Jan 7, 2020
src/@next/components/organisms/ProductVariantPicker/ProductVariantAttributeSelect.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/ProductVariantPicker/ProductVariantAttributeSelect.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/ProductVariantPicker/ProductVariantAttributeSelect.tsx
Outdated
Show resolved
Hide resolved
src/@next/components/organisms/ProductVariantPicker/ProductVariantPicker.tsx
Outdated
Show resolved
Hide resolved
hello are you ready to berge this ? it could help. Thanks for all. |
@maarcingebala i'm desesperate :-(, and you are the one that could help with merging this. Thanks for help. regards |
maarcingebala
approved these changes
Jan 13, 2020
Deploy preview for saleor-storefront-stage processing. Building with commit 0d6a6e5 https://app.netlify.com/sites/saleor-storefront-stage/deploys/5e1c813fbcfa1100080803b1 |
orzechdev
deleted the
fix/unsupported_multiple_product_variant_attributes
branch
January 13, 2020 15:00
@maarcingebala thaannnnnnks :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and added functionalities:
toLocaleString()
function.Screenshots
For given possible variants:
By default no selection is applied:
After cotton selection, red and turquoise has been disabled as not available variants left for them:
Also, there is an option to use right sidebar as a selection menu:
Selection of all attributes and valid quantity enables add to basket possibility:
Pull Request Checklist