Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

fix issue #299 - display filters when no product was found #319

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

aldomonteiro
Copy link
Contributor

@aldomonteiro aldomonteiro commented May 8, 2019

I want to merge this change because...

Fixes #299

Screenshots

With this correction, when the filters don't match any product, the filters keep open and the user can correct it. The change affects 2 pages:

  1. The "Search" page:
    image

  2. The "Categories" page:
    image

Pull Request Checklist

  1. [N/A] All visible strings are translated with proper context.
  2. [N/A] All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. [X ] The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@NyanKiyoshi NyanKiyoshi requested a review from piotrgrundas May 8, 2019 15:54
<OfflinePlaceholder />
);
<OfflinePlaceholder />
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the style was correct. Use prettier in vscode with default settings.

Copy link
Contributor

@AlicjaSzu AlicjaSzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProductFilters and ProductsList can be wrapped in one condition:

{canDisplayProducts && ( <> <ProductFilters /> <ProductsList /> </> )}

@salwator
Copy link
Contributor

@aldomonteiro could you please check this PR and apply changes needed?

@aldomonteiro
Copy link
Contributor Author

@aldomonteiro could you please check this PR and apply changes needed?

Done!

@bogdal bogdal merged commit 7861067 into saleor:master Jun 28, 2019
@bogdal
Copy link
Contributor

bogdal commented Jun 28, 2019

Great work @aldomonteiro 👍

@bogdal bogdal mentioned this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters are not visible when no product is matching
5 participants