This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 672
Fix invalid handling of checkouts without shipping #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for saleor-storefront-stage processing. Building with commit 9a3b5c2 https://app.netlify.com/sites/saleor-storefront-stage/deploys/5e2ef58267651a000b4a91e5 |
mateuszkula
reviewed
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Notion:
Error: Cannot find module 'graphql/validation/rules/PossibleTypeExtensions'
whenapollo codegen:generate --target=typescript types
executed.Refactor (tldr: redirection and determination of checkout route is moved to a higher position in the components hierarchy):
useCheckoutStepState()
hook to handle state of step and removed step out of checkout context - it should not be there as there it is not connected with context, step state is just memoization of step, where the user left his/her work. Moreover step state now can depend on other contexts and data, so it is not tight coupled with checkout context anymore.StepCheck
out of checkout pages - the logic of redirection to prevent user from entering invalid step by manually pasting the url is moved to mainindex.js
of checkout, i.e.CheckoutApp
.CheckoutDispatcher
and move it toroutes
directory asCheckoutRouteDispatcher
.Screenshots
Pull Request Checklist