Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Refactor FilterAttribute to AttributeValuesChecklist #610

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Refactor FilterAttribute to AttributeValuesChecklist #610

merged 2 commits into from
Feb 14, 2020

Conversation

orzechdev
Copy link
Contributor

I want to merge this change because... I changed FilterAttribute to AttributeValuesChecklist with:

  • remove passing filters as prop to make component simpler
  • rename it, as now it is no longer tight coupled with filtering functionality
  • due to removed filters prop, delegate determining checkbox state to upper-level components

@netlify
Copy link

netlify bot commented Feb 14, 2020 •
edited
Loading

Deploy preview for saleor-storefront-stage processing.

Building with commit 6699479

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5e46a76fc971900008806f56

@orzechdev orzechdev marked this pull request as ready for review February 14, 2020 14:07
@orzechdev orzechdev self-assigned this Feb 14, 2020
@orzechdev orzechdev merged commit 191da82 into master Feb 14, 2020
@orzechdev orzechdev deleted the refactor/attribute-values-checklist branch February 14, 2020 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mateuszkula mateuszkula mateuszkula approved these changes

Assignees

@orzechdev orzechdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orzechdev @mateuszkula