-
Notifications
You must be signed in to change notification settings - Fork 674
Conversation
Deploy preview for saleor-storefront-stage processing. Building with commit f2c3031 https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ec5786c171f230007389ec1 |
Hi, thank you for contributing! It is definitely important. May I ask you for a rebase with master to resolve conflicts? We will then see that all tests pass and we will be able to merge changes. |
This pull request introduces 2 alerts when merging 071c2ea into b296500 - view on LGTM.com new alerts:
|
@orzechdev I merge and resolved the conflicts, The only test that is not passing is the build because it requires the API_URL. But not sure how to solve this. Do you have any suggestion? |
@Bomba1990 Oh, great! We do not have configured CircleCI to run tests with forked repos, but I have run it locally and it passes all of them. Unfortunately, I see there is unnecessarily duplicated |
…erwritten output property
@orzechdev Done, I Fixed the reported by LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominik-zeglen I reviewed the requested, let me now if left any other comment. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@dominik-zeglen @orzechdev Do we have any update on this? |
I want to merge this change because. I think is important to have the ability to edit the location of the assets with the STATIC_URL environment parameter like the dashboard application.
Pull Request Checklist