Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Support for static url #721

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Conversation

marianoeramirez
Copy link
Contributor

I want to merge this change because. I think is important to have the ability to edit the location of the assets with the STATIC_URL environment parameter like the dashboard application.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented May 20, 2020

Deploy preview for saleor-storefront-stage processing.

Building with commit f2c3031

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ec5786c171f230007389ec1

@orzechdev
Copy link
Contributor

Hi, thank you for contributing! It is definitely important. May I ask you for a rebase with master to resolve conflicts? We will then see that all tests pass and we will be able to merge changes.

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request introduces 2 alerts when merging 071c2ea into b296500 - view on LGTM.com

new alerts:

  • 1 for Duplicate property
  • 1 for Overwritten property

@marianoeramirez
Copy link
Contributor Author

@orzechdev I merge and resolved the conflicts, The only test that is not passing is the build because it requires the API_URL. But not sure how to solve this. Do you have any suggestion?

@orzechdev
Copy link
Contributor

orzechdev commented Jun 29, 2020

@Bomba1990 Oh, great! We do not have configured CircleCI to run tests with forked repos, but I have run it locally and it passes all of them. Unfortunately, I see there is unnecessarily duplicated devtool: "source-map", and also output property, which should be removed in the config/webpack/config.base.js - as reported by lgtm bot. May you fix it too?

@marianoeramirez
Copy link
Contributor Author

@orzechdev Done, I Fixed the reported by LGTM.

@orzechdev orzechdev self-requested a review June 29, 2020 13:56
Copy link
Contributor

@orzechdev orzechdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally:
Zrzut ekranu 2020-06-29 o 16 01 07

config/webpack/config.base.js Outdated Show resolved Hide resolved
config/webpack/config.base.js Outdated Show resolved Hide resolved
config/webpack/config.base.js Show resolved Hide resolved
@marianoeramirez
Copy link
Contributor Author

@dominik-zeglen I reviewed the requested, let me now if left any other comment.

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2020
@marianoeramirez
Copy link
Contributor Author

@dominik-zeglen @orzechdev Do we have any update on this?

@stale stale bot removed the stale label Aug 31, 2020
@dominik-zeglen dominik-zeglen changed the base branch from master to fix/static-url September 29, 2020 11:39
@dominik-zeglen dominik-zeglen merged commit e259378 into saleor:fix/static-url Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants