Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 300 - Update field display to show comment text #300

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

markbond1007
Copy link

Include the Comment text set in studio as a small text under the field if present and in Edit/Create mode

Description

Added a <small> tag surrounded by <div *ngIf that displays the comment as set in the field configuration in studio

Motivation and Context

Studio has the capability to have field meta data beyond that currently used, while this currently isnt easily translatable, for most peoples use this can be updated where necessary as such it seems right that its displayed int he front end edit forms. As well we have clients that would like this functionality.

How To Test This

There is default content in these fields, test by going to any Account and edit it, the text should appear under the edit portion of the field ONLY when in edit/create mode.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Include the Comment text set in studio as a small text under the field if present and in Edit/Create mode
@SuiteBot
Copy link

SuiteBot commented Jul 21, 2023

CLA assistant check
All committers have signed the CLA.

@jack7anderson7
Copy link
Contributor

Hi @markbond1007,

Thanks for the contribution! Just one note, could you update the commit message to follow the format: Fix #num - message in this case, the number is the same as the Pull Request number.

Thanks,
Jack

@markbond1007 markbond1007 changed the title Update field display to show comment text Fix: 300 - Update field display to show comment text Sep 14, 2023
@markbond1007
Copy link
Author

Hi @jack7anderson7

Hopefully thats what you needed?

Regards

Mark

@jack7anderson7
Copy link
Contributor

Hi @jack7anderson7

Hopefully thats what you needed?

Regards

Mark

Hey @markbond1007,

It appears you only changed the title of the PR and not the commit itself. You can change the commit by checking out the branch, edit the commit message of the commit and re-pushing.

Thanks,
Jack

@markbond1007
Copy link
Author

Hi @jack7anderson7
Hopefully thats what you needed?
Regards
Mark

Hey @markbond1007,

It appears you only changed the title of the PR and not the commit itself. You can change the commit by checking out the branch, edit the commit message of the commit and re-pushing.

Thanks, Jack

Ahh well I've been making my edits/commits directly on github, can't really see how to do that here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants