Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legacy] Fix #319 - Prevent css sanitization #320

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/app/common/src/lib/record/field.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export interface FieldMetadata {
extraOptions?: Option[];
onClick?: FieldClickCallback;
tinymce?: any;
trustHTML?: boolean;
date_time_format?: string;
displayLogicResetOn?: string;

Expand Down
1 change: 1 addition & 0 deletions core/app/core/src/lib/fields/base-fields.manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ export const baseViewFieldsMap: FieldComponentMap = {
'bool.detail': BooleanDetailFieldComponent,
'bool.edit': BooleanEditFieldComponent,
'bool.filter': BooleanFilterFieldComponent,
'html-native.detail': HtmlDetailFieldComponent,
'html.detail': TinymceDetailFieldComponent,
'html.edit': TinymceEditFieldComponent
};
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<! --
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand All @@ -25,4 +25,5 @@
* the words "Supercharged by SuiteCRM".
*/
-->
<div class="field-html text-break" [innerHTML]="field.value"></div>
<div class="field-html text-break" [innerHTML]="!field.metadata?.trustHTML? field.value : (field.value | safeHtml)"></div>

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand Down Expand Up @@ -28,14 +28,16 @@ import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {FormsModule} from '@angular/forms';
import {HtmlDetailFieldComponent} from './html.component';
import { SafeHtmlModule } from '../../../../pipes/safe-html/safe-html.module'

@NgModule({
declarations: [HtmlDetailFieldComponent],
exports: [HtmlDetailFieldComponent],
imports: [
CommonModule,
FormsModule
]
imports: [
CommonModule,
FormsModule,
SafeHtmlModule,
],
})
export class HtmlDetailFieldModule {
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<! --
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand All @@ -25,9 +25,14 @@
* the words "Supercharged by SuiteCRM".
*/
-->
<editor
class="field-html text-break"
[initialValue]="initialValue"
[init]="settings"
[disabled]="true"
></editor>
<ng-container *ngIf="field?.metadata?.trustHTML">
<div class="field-html text-break" [innerHTML]="this.initialValue | safeHtml"></div>
</ng-container>
<ng-container *ngIf="!field?.metadata?.trustHTML">
<editor
class="field-html text-break"
[initialValue]="initialValue"
[init]="settings"
[disabled]="true"
></editor>
</ng-container>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand Down Expand Up @@ -41,7 +41,7 @@ import {FieldLogicDisplayManager} from '../../../field-logic-display/field-logic
export class TinymceDetailFieldComponent extends BaseFieldComponent {

settings: any = {};
initialValue: string = '';
initialValue = '';

constructor(
protected typeFormatter: DataTypeFormatter,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2021 SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
Expand Down Expand Up @@ -29,6 +29,8 @@ import {CommonModule} from '@angular/common';
import {FormsModule, ReactiveFormsModule} from '@angular/forms';
import {TinymceDetailFieldComponent} from './tinymce.component';
import {EditorModule, TINYMCE_SCRIPT_SRC} from '@tinymce/tinymce-angular';
import { SafeHtmlModule } from '../../../../pipes/safe-html/safe-html.module';


@NgModule({
declarations: [TinymceDetailFieldComponent],
Expand All @@ -37,7 +39,8 @@ import {EditorModule, TINYMCE_SCRIPT_SRC} from '@tinymce/tinymce-angular';
CommonModule,
FormsModule,
EditorModule,
ReactiveFormsModule
ReactiveFormsModule,
SafeHtmlModule
],
providers: [
{provide: TINYMCE_SCRIPT_SRC, useValue: 'tinymce/tinymce.min.js'}
Expand Down
44 changes: 44 additions & 0 deletions core/app/core/src/lib/pipes/safe-html/safe-html.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
* Free Software Foundation with the addition of the following permission added
* to Section 15 as permitted in Section 7(a): FOR ANY PART OF THE COVERED WORK
* IN WHICH THE COPYRIGHT IS OWNED BY SALESAGILITY, SALESAGILITY DISCLAIMS THE
* WARRANTY OF NON INFRINGEMENT OF THIRD PARTY RIGHTS.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
* details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* In accordance with Section 7(b) of the GNU Affero General Public License
* version 3, these Appropriate Legal Notices must retain the display of the
* "Supercharged by SuiteCRM" logo. If the display of the logos is not reasonably
* feasible for technical reasons, the Appropriate Legal Notices must display
* the words "Supercharged by SuiteCRM".
*/

import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {SafeHtmlPipe} from './safe-html.pipe';


@NgModule({
declarations: [
SafeHtmlPipe
],
exports: [
SafeHtmlPipe
],
imports: [
CommonModule
]
})
export class SafeHtmlModule {
}
41 changes: 41 additions & 0 deletions core/app/core/src/lib/pipes/safe-html/safe-html.pipe.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/**
* SuiteCRM is a customer relationship management program developed by SalesAgility Ltd.
* Copyright (C) 2023 SalesAgility Ltd.
*
* This program is free software; you can redistribute it and/or modify it under
* the terms of the GNU Affero General Public License version 3 as published by the
* Free Software Foundation with the addition of the following permission added
* to Section 15 as permitted in Section 7(a): FOR ANY PART OF THE COVERED WORK
* IN WHICH THE COPYRIGHT IS OWNED BY SALESAGILITY, SALESAGILITY DISCLAIMS THE
* WARRANTY OF NON INFRINGEMENT OF THIRD PARTY RIGHTS.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
* details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* In accordance with Section 7(b) of the GNU Affero General Public License
* version 3, these Appropriate Legal Notices must retain the display of the
* "Supercharged by SuiteCRM" logo. If the display of the logos is not reasonably
* feasible for technical reasons, the Appropriate Legal Notices must display
* the words "Supercharged by SuiteCRM".
*/

import {Pipe, PipeTransform} from '@angular/core';
import {DomSanitizer, SafeHtml} from '@angular/platform-browser';

@Pipe({
name: 'safeHtml'
})
export class SafeHtmlPipe implements PipeTransform {

constructor(private sanitizer: DomSanitizer) {
}

transform(value: string): SafeHtml {
return this.sanitizer.bypassSecurityTrustHtml(value);
}
}
5 changes: 5 additions & 0 deletions public/legacy/data/SugarBean.php
Original file line number Diff line number Diff line change
Expand Up @@ -2622,6 +2622,11 @@ public function cleanBean()
$type .= $def['dbType'];
}

$purifyHtml = $def['metadata']['purifyHtml'] ?? true;
if ($purifyHtml === false) {
return;
}

if (isset($def['type']) && ($def['type'] == 'html' || $def['type'] == 'longhtml')) {
$this->$key = purify_html($this->$key);
} elseif (
Expand Down