Feature date components change proposal #400
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of solving #399 and understanding the Date component in edit mode and filter mode, to improve the readability and functionality this proposal was created.
Description
core/app/core/src/lib/fields/base/base-field.component.ts:257
of fix Status field is dependent on state field but it not responding to changes #323, but I do not want to leave this change proposal uncommitted.core/app/core/src/lib/fields/date/templates/edit/date.component.ts:[64~75, 97~124]
: three new functions were created to centralise value assignationcore/app/core/src/lib/fields/date/templates/filter/date.component.ts:[67~74, 101~127]
: four new functions were created to centralise value assignation.core/app/core/src/lib/fields/date/templates/edit/date.component.html:[35~36]
andcore/app/core/src/lib/fields/date/templates/filter/date.component.html:[35~36]
we do not need to react tongModelChange
of the component to updatethis.field.value
andthis.dateModel
, that is done throughthis.field.formControl
changes that triggerssetFieldValue
function.Motivation and Context
I do not want to leave this change proposal uncommitted.
How To Test This
Types of changes
Final checklist