Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.php #505

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

advocotek
Copy link

@advocotek advocotek commented Jun 26, 2024

For multibyte turkish characters converted wrongly. For instance:
ANNELERİ İÇİN BAKIYORLAR --> ANNELERİ İÇİN BAKIYORLAR.

Explanation
https://stackoverflow.com/questions/5679715/htmlentities-destroys-utf-8-strings

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

For multibyte turkish characters converted wrongly. 
For instance:
 ANNELERİ İÇİN BAKIYORLAR --> ANNELERİ İÇİN BAKIYORLAR.

Explanation
https://stackoverflow.com/questions/5679715/htmlentities-destroys-utf-8-strings
@SuiteBot
Copy link

SuiteBot commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@advocotek
Copy link
Author

I've noticed that, github corrects character in description as if there's no problem. However Suitecrm Frontend displays Ç as & C c e d i l ;
binary

@pgorod
Copy link
Contributor

pgorod commented Jun 26, 2024

@advocotek if you put your code inside back-ticks, the display won't be changed. Like this:

` Ç `

@advocotek
Copy link
Author

It is not something I can change. This is a text saved in database. It's displayed correctly in DB with SQL and displayed correctly in 8.6.0. This problem is new. It is not about back-tick. String enters to the code correctly in UTF8 and function break the structure. Function needs to be changed.

@advocotek
Copy link
Author

8.6.1:
image

DB:
image

8.6.1 proposed fix:
image

@pgorod
Copy link
Contributor

pgorod commented Jun 26, 2024

My comment was about the way Github handles your text here, it was not about the SuiteCRM bug / database...

@advocotek
Copy link
Author

oops. Sorry. I misunderstood :)

@yunusyerli1 yunusyerli1 added the Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants