Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name typo in getEmailInfo #539

Closed
wants to merge 1 commit into from

Conversation

LoLei
Copy link

@LoLei LoLei commented Sep 2, 2024

Description

Changes the fromddr variable to fromaddr. As otherwise, this variable is not used.

Motivation and Context

Make the else branch of the getEmailInfo in User.php functional.

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7
Copy link
Contributor

jack7anderson7 commented Oct 7, 2024

Hi @LoLei

Thank you for the contribution.

As the changed file is within the legacy folder this change would be more suited to our SuireCRM 7 Repo.

Could you please close this PR and re-create this on the SuiteCRM 7 Repo https://github.com/salesagility/SuiteCRM.

Alternatively, if you prefer, we can do this.

Thanks,
Jack

@LoLei
Copy link
Author

LoLei commented Oct 9, 2024

@LoLei LoLei closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants