Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10488 - Expand the number of filters in message queue views #10489

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

SinergiaCRM
Copy link
Contributor

Description

This PR expands the number of filters available for the Email Queue module.

Motivation and Context

#10488

How To Test This

  1. Create a campaign with contacts, accounts, leads and users.
  2. Send one or more marketing emails.
  3. Access the message queue view and verify that the different filters added work correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Aug 6, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your contribution,

would you be so kind to check the suggested changes in the vardefs.php file as there might be some discrepancies:

image

Thanks in advance!

Regards,
Serhii

@SinergiaCRM
Copy link
Contributor Author

Hello @SinergiaCRM,

thanks for your contribution,

would you be so kind to check the suggested changes in the vardefs.php file as there might be some discrepancies:

image

Thanks in advance!

Regards, Serhii

Hi @serhiisamko091184, removed lines added by mistake to the user_id field.
Thanks!

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Aug 6, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for the quick reply and changes to the PR!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Aug 22, 2024
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Sep 5, 2024
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, new filter options make sense and work as expected.

@jack7anderson7 jack7anderson7 merged commit 886d0ae into salesagility:hotfix Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants