Fix #4075 - No way to add email signature after adding email template #9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on SuiteCRM. There might be relevant details there: https://community.suitecrm.com/t/dealing-with-signature-and-templates/84010/2 |
mattlorimer
added
Branch:Hotfix
Status:Assessed
mattlorimer
approved these changes
Feb 28, 2022
mattlorimer
added
the
Status: Ready to Merge
|
This pull request has been mentioned on SuiteCRM. There might be relevant details there: https://community.suitecrm.com/t/e-mail-signature-not-loading-automatically-or-with-lag/84975/3 |
|
This pull request has been mentioned on SuiteCRM. There might be relevant details there: https://community.suitecrm.com/t/email-templates-not-overwriting-signature-7-12-x/86196/2 |
|
See the Forum thread kindly posted by SuiteBot above ☝️ for some peculiar use-cases where this new way of doing things isn't working too well.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populates
self.updateSignature = function ()in a superior scope in order to be called in$.fn.EmailsComposeView.onTemplateSelectSteps to reproduce and test are in issue #4075
Motivation and Context
The signature should stay after adding the template
Types of changes
Final checklist