Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] [ANDROID] Add check google-services plugin does not exist #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucaboy
Copy link

@lucaboy lucaboy commented Aug 24, 2020

No description provided.

@billmote
Copy link
Collaborator

When would this apply? The included marketingcloudsdk.gradle adds the dependency for you and then the plugin is applied.

@lucaboy
Copy link
Author

lucaboy commented Aug 25, 2020

If there is another library that add the same plugin before your gradle plugin is applied, you'll get the following error: "Cannot add extension with name 'googleServices', as there is an extension already registered with that name" and the build will fail.

@jefflnorton
Copy link

This may be useful if this plugin is added to an Ionic Capacitor project. In this case the Capacitor project will apply the plugin in the app module.

@cabelotaina
Copy link

In cordova-android 9 I made:

<preference name="GradlePluginGoogleServicesEnabled" value="false" />

@dtarnawsky
Copy link

Any update on whether this PR can be included in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants