-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for plain text breadcrumb elements #243
Add support for plain text breadcrumb elements #243
Conversation
By analyzing the blame information on this pull request, we identified @brandonferrua, @kaelig and @aputinski to be potential reviewers |
@@ -32,7 +32,7 @@ | |||
|
|||
&:first-child { | |||
|
|||
> a { | |||
> a, span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each selector in a comma sequence should be on its own single line
@@ -21,7 +21,8 @@ | |||
left: (($spacing-x-small / 2) * -1); | |||
} | |||
|
|||
> a { | |||
> a, | |||
span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a > span
to avoid propagation of styles to potential other children.
A huge "thank you" for your contribution, @pixelprodotco! Let us check first if this pattern is desirable from an accessibility / usability point of view, and we'll get back to you shortly. |
sounds good. thanks. |
Thanks again for our contribution, @pixelprodotco! Our design team looked into this pattern and it seems the Design System's guidelines should not include the proposed variant. In case this pops up in future design discussions I'll make sure to point to your contribution. |
Changes proposed in this PR:
Reviewer, please refer to this "definition of done" checklist:
Please confirm the following before accepting this PR:
After accepting, please remind developer to merge code into all appropriate development branches.