Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plain text breadcrumb elements #243

Closed
wants to merge 1 commit into from
Closed

Add support for plain text breadcrumb elements #243

wants to merge 1 commit into from

Conversation

pixelprodev
Copy link

Changes proposed in this PR:

  • Add span elements to already existing declarations for breadcrumb styles

Reviewer, please refer to this "definition of done" checklist:

Please confirm the following before accepting this PR:

  • Any acceptance criteria have been met
  • Functionality has been manually tested in a testing app on desktop
  • Functionality has been manually tested in a testing app on phone
  • Any necessary unit, regression and integration tests have been added or updated
  • All automated tests pass including accessibility
  • No linting or build errors
  • No high priority bugs are open
  • All documentation has been updated
  • Release notes have been updated

After accepting, please remind developer to merge code into all appropriate development branches.

@salesforce-ux-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @brandonferrua, @kaelig and @aputinski to be potential reviewers

@@ -32,7 +32,7 @@

&:first-child {

> a {
> a, span {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line

@pixelprodev
Copy link
Author

#242

@@ -21,7 +21,8 @@
left: (($spacing-x-small / 2) * -1);
}

> a {
> a,
span {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a > span to avoid propagation of styles to potential other children.

@kaelig
Copy link
Contributor

kaelig commented Jun 16, 2016

A huge "thank you" for your contribution, @pixelprodotco!

Let us check first if this pattern is desirable from an accessibility / usability point of view, and we'll get back to you shortly.

@pixelprodev
Copy link
Author

sounds good. thanks.

@kaelig
Copy link
Contributor

kaelig commented Jun 20, 2016

Thanks again for our contribution, @pixelprodotco! Our design team looked into this pattern and it seems the Design System's guidelines should not include the proposed variant. In case this pops up in future design discussions I'll make sure to point to your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants