Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves value from from attribute #144

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Moves value from from attribute #144

merged 1 commit into from
Jun 4, 2018

Conversation

craveytrain
Copy link
Contributor

Simple syntax adjustment to move the value to it's proper place based on the examples.

Resolves #142

@salesforce-cla
Copy link

salesforce-cla bot commented Mar 1, 2018

Thanks for the contribution! Before we can merge this, we need @craveytrain to sign the Salesforce Contributor License Agreement.

@aputinski
Copy link
Contributor

Good catch — we'll probably have to bump to 8.0.0 though because this would break anyone relying on the broken behavior.

@craveytrain
Copy link
Contributor Author

Makes sense to me. Happy to help.

@aputinski
Copy link
Contributor

aputinski commented Mar 22, 2018

I haven't forgotten about this PR — I'll merge it in with #146 since it will also be a major version bump.

@craveytrain
Copy link
Contributor Author

Sounds good.

@aputinski
Copy link
Contributor

aputinski commented Mar 23, 2018

Quick question — I don't work with Android / XML much, is your proposed change what most people would expect or should we just update the docs?

@craveytrain
Copy link
Contributor Author

That's the format my android developers were looking for but I confess I'm not familiar with the platform requirements myself.

@larsonjj
Copy link

larsonjj commented Apr 3, 2018

Hey @craveytrain and @aputinski,

Just wanted to chime in on this PR as it's a start in the right direction. After chatting with an Android engineer on my team, it seems that <property> tags don't really mean anything when it comes to Android resources. Apparently each value should be mapped to a tag that matches it's type.

For example, all colors should be mapped to the <color> tag, all dimensions (px, rem) should be mapped to the <dimen> tag, etc.

More info in the Android docs: https://developer.android.com/guide/topics/resources/providing-resources.html

@aputinski aputinski merged commit 9b9306a into salesforce-ux:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants