-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves value from from attribute #144
Moves value from from attribute #144
Conversation
Thanks for the contribution! Before we can merge this, we need @craveytrain to sign the Salesforce Contributor License Agreement. |
Good catch — we'll probably have to bump to |
Makes sense to me. Happy to help. |
I haven't forgotten about this PR — I'll merge it in with #146 since it will also be a major version bump. |
Sounds good. |
Quick question — I don't work with Android / XML much, is your proposed change what most people would expect or should we just update the docs? |
That's the format my android developers were looking for but I confess I'm not familiar with the platform requirements myself. |
Hey @craveytrain and @aputinski, Just wanted to chime in on this PR as it's a start in the right direction. After chatting with an Android engineer on my team, it seems that For example, all colors should be mapped to the More info in the Android docs: https://developer.android.com/guide/topics/resources/providing-resources.html |
Simple syntax adjustment to move the value to it's proper place based on the examples.
Resolves #142