Cbayer jdk17 spring 3.0.2 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests still failing though. App context doesn't come up. |
build.gradle
Outdated
| @@ -5,14 +5,14 @@ buildscript { | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
| classpath("org.springframework.boot:spring-boot-gradle-plugin:2.5.6") | |||
| classpath("org.springframework.boot:spring-boot-gradle-plugin:3.0.2") | |||
There was a problem hiding this comment.
Why not add this to the top-level gradle.properties instead?
carbonj.service/build.gradle
Outdated
| exclude group: 'org.apache.logging.log4j', module: 'log4j-to-slf4j' | ||
| exclude group: 'org.apache.logging.log4j', module: 'log4j-api' | ||
| } | ||
| compile group:"org.springframework.boot", name:"spring-boot-starter-web", version:"2.7.5" | ||
| compile group:"org.springframework.boot", name:"spring-boot-starter-jetty", version:"2.7.5" | ||
| implementation group:"org.springframework.boot", name:"spring-boot-starter-web", version:"3.0.2" |
There was a problem hiding this comment.
Shouldn't need a version on dependencies when using the spring boot plugin.
There was a problem hiding this comment.
unfortunately it is needed here.. I think it works for project dependencies but not for buildscript dependencies.
| ncsaLog.setAppend( true ); | ||
| ncsaLog.setLogTimeZone( "GMT" ); | ||
| ncsaLog.setRetainDays( jettyRequestLogRetentionDays ); | ||
| // NCSARequestLog ncsaLog = new NCSARequestLog( jettyLogfilePath ); |
There was a problem hiding this comment.
Removing request log?
There was a problem hiding this comment.
Good catch. The class was removed from Jetty. Not sure how to get this functionality back.
...nj.service/src/main/java/com/demandware/carbonj/service/engine/kinesis/cfgCheckPointMgr.java
Show resolved
Hide resolved
chrbayer84
commented
Feb 2, 2023
|
|
||
| } | ||
|
|
||
| test { | ||
| maxHeapSize = "2g" | ||
| jvmArgs = [ | ||
| '--add-opens', 'java.base/java.util=ALL-UNNAMED', |
There was a problem hiding this comment.
If that's removed, one of the test cases around CarbonJEvent logs will fail.
twoversionsofme
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #151 #584 #584 #586 #587 #583 #593