-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trial Bar Component #2006
Comments
Here is my initial props proposal:
|
@garygong @davidlygagnon Please see if the props are plausible, I will raise a PR for the same tomorrow morning. |
@garygong We may want this API to look something more like |
If we were to have the API be more like TrialBar
TrialBarButtonSame props as TrialBarDropdownSame props as ExampleHere's a sample using the example from the SLDS page.
|
Looks good to me. Two comments
|
Good point. I updated the example above to use time left. I left the success link (button??) in a render function so that consumers can have that additional flexibility. By "link/button mix of props" do you mean that we'd have something like a |
Yes. Something like that. We’d deprecate link variant I think so that the link prop could be any of the button variants. Although link variant may be a visual variant, so we might want to keep it. It needs to be explored. |
@aswinshenoy might be interested in picking up the button/link issue. The user story still needs to be groomed /spec decides, but props could be proposed. @aswinshenoy would you be interested in working on the missing button options for the first evaluation period? |
@interactivellama Did we file an issue for the button/link? I noticed that when testing the trial bar component. |
@davidlygagnon No, I haven't created an issue. I was waiting for someone to propose an API for it. |
Ok - I'll create the issue and TBD for props proposal so that we don't forget. |
Here's the new issue: #2090 |
Add Trial Bar Component according to specs https://lightningdesignsystem.com/components/trial-bar/
I am working on this and will send a prop proposal soon.
The text was updated successfully, but these errors were encountered: