-
Notifications
You must be signed in to change notification settings - Fork 433
Add Dynamic Icons Component #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dynamic Icons Component #1780
Conversation
|
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. TravisCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause TravisCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
|
Thanks for the contribution! Before we can merge this, we need @tanhengyeow to sign the Salesforce.com Contributor License Agreement. |
008bb1c to
e06e828
Compare
e06e828 to
b989aa5
Compare
|
@kevinparkerson Please see feedback at #1359 (comment) |
|
@tanhengyeow your contribution here is much appreciated! It solves the issue, just a few housekeeping changes I'm adding before we merge it. Thanks again for your work! |
# Conflicts: # package-lock.json # tests/__snapshots__/story-based-tests.snapshot-test.js.snap # utilities/constants.js
Fixes #1359
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.