-
Notifications
You must be signed in to change notification settings - Fork 33
@W-15205324 New rule - disallow import of scoped modules #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Shinoni
merged 18 commits into
salesforce:master
from
Shinoni:eslint-no-import-scoped-modules
Oct 18, 2024
+415
−19
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e0a17cc
New rule - disallow import of scoped modules
lesya7 72b0df4
Addressin the comments
lesya7 1b63a2c
Small correction in the title
lesya7 a2b6e56
Remove the link for formFactor
lesya7 9ae6c35
Remove the rule regarding the dynamic imports
lesya7 d5c9566
Remove the link to the internal doc
lesya7 b7a4882
Update docs/rules/no-form-factor-in-ssrable-components.md
Shinoni c272abe
Update lib/rules/no-static-imports-of-user-specific-scoped-modules-in…
Shinoni f4e7a4d
Fixing the failing test
lesya7 c6deca5
Update lib/rules/no-static-imports-of-user-specific-scoped-modules-in…
Shinoni c10a948
Addressing feedabck
lesya7 0c150c8
Adding the link to the public doc
lesya7 be994f2
Merge branch 'master' into eslint-no-import-scoped-modules
lesya7 15ace17
rebasing
lesya7 3bd499e
Fix the link.
Shinoni 0f4a3cb
Merge branch 'salesforce:master' into eslint-no-import-scoped-modules
Shinoni c527dce
Renaming
lesya7 7994a7f
Removing the config
lesya7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rebasing
- Loading branch information
commit 15ace179443e13ceda54d2469b159a8426871c41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -105,6 +105,7 @@ To choose from three configuration settings, install the [`eslint-config-lwc`](h | |||||
| [lwc/no-unsupported-ssr-properties](./docs/rules/no-unsupported-ssr-properties.md) | disallow access of unsupported properties in SSR | | | ||||||
| [lwc/no-node-env-in-ssr](./docs/rules/no-node-env-in-ssr.md) | disallow usage of process.env.NODE_ENV in SSR | | | ||||||
| [lwc/valid-graphql-wire-adapter-callback-parameters](./docs/rules/valid-graphql-wire-adapter-callback-parameters.md) | ensure graphql wire adapters are using 'errors' instead of 'error' | | | ||||||
| [lwc/no-host-mutation-in-connected-callback](./docs/rules/no-host-mutation-in-connected-callback.md) | disallow the host element mutation in 'connectedCallback' | | | ||||||
| [lwc/no-static-imports-of-user-specific-scoped-modules-in-ssrable-components](./docs/rules/no-static-imports-of-user-specific-scoped-modules-in-ssrable-components.md) | disallow static imports of user-specific scoped modules in SSR-able components | | | ||||||
| [lwc/no-form-factor-in-ssrable-components](./docs/rules/no-form-factor-in-ssrable-components.md) | disallow formFactor in SSR-able components | | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.