fix: support eslint 8 and 7 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 9, 2021
| "functions": 95, | ||
| "lines": 93, | ||
| "statements": 93, | ||
| "functions": 88, |
There was a problem hiding this comment.
Coverage is still the same for ESLint 7, but it drops for ESLint 8. Unless we run tests in both versions and merge the coverage results, I don't think it's worth it to keep these so high. It's easier to just drop the coverage threshold.
jye-sf
approved these changes
Nov 9, 2021
ravijayaramappa
approved these changes
Nov 9, 2021
Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
pmdartus
approved these changes
Nov 10, 2021
ekashida
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies and adds supports for ESLint 8. ESLint 7 is still supported.