feat: add support for pattern matching in rule no-unexpected-wire-adapter-usages #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Implementation lgtm but would like to hear from @pmdartus whether there was a reason why this feature was added for no-unknown-wire-adapters and not this plugin.
| }`, | ||
| options: [ | ||
| { | ||
| adapters: [{ module: '@salesforce/apex/*', identifier: '*' }], |
There was a problem hiding this comment.
This test really confused me until I saw that the pattern used * instead of **.
pmdartus
requested changes
Jun 3, 2022
…pter-usages @W-11238920
seckardt
force-pushed
the
feature/240-pattern-support-no-unexpected-wire-adapter-usages
branch
from
537fd2f to
d8fdb76
Compare
ekashida
approved these changes
Jun 7, 2022
pmdartus
approved these changes
Jun 8, 2022
seckardt
deleted the
feature/240-pattern-support-no-unexpected-wire-adapter-usages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.