Support custom broker settings #12
Comments
|
Hi @Cs4r thanks for the suggestion! I'd love to understand/talk through how exactly you'd like to see this work. I could see a constructor argument being added to KafkaTestServer that would allow for passing in broker settings. That seems like a super easy thing to add. I'm curious how you would see that being used by the Kafka-JUnit4 ClassRule? Would you just pass it on the constructor for SharedKafkaTestResource? IE: @ClassRule
public static final SharedKafkaTestResource sharedKafkaTestResource = new SharedKafkaTestResource(customBrokerProperties);How about for the JUnit5 variant? Perhaps something similar making use of the |
|
Hi @Crim, Thanks for your quick response. For me it would be very useful to tune some of the broker settings in order to proof that my custom consumer/producer behaves correctly in certain particular scenarios. e.g: what would happen if it tries to send a message to a topic that doesn't exist? That's not currently possible since I also thought of adding an argument constructor to It doesn't seem to be very complicated unless I am missing something. Regards |
|
@Cs4r Can you please review the READMEs to verify this new behavior will satisfy your needs? |
|
Thank you for being so quick addressing the issue, I appreciate it. |
for #12 - [Issue-12](#12) Added ability to pass broker properties to be used by test kafka service instance. - Added helper method getAdminClient() on KafkaTestServer to get a configured AdminClient instance. - Deprecated Kafka-JUnit5 @ExtendWith annotation implementations. This has been replaced in favor of @RegisterExtension annotation. Review [README.md](kafka-junit5/README.md) for more information on updated usage instructions. - Deprecated KafkaTestServer constructor: `public KafkaTestServer(final String localHostname)` This constructor was replaced with the constructor `KafkaTestServer(final Properties overrideBrokerProperties)` where overrideBrokerProperties should contain the property `host.name` set to the hostname or IP address Kafka should use.
|
I just published 2.3.0 to the maven repository. If you run into any troubles or have any other great ideas feel free to submit a new issue. Thanks! |
KafkaTestServer doesn't support any way of overriding the kafka broker settings.
e.g:
num.io.threads,auto.create.topics.enable,portandzookeeper.session.timeout.msare all hardcoded inKafkaTestServer::start.The text was updated successfully, but these errors were encountered: