fix(ssr): fix constructor with args

Fixes #5080
salesforce · Jan 3, 2025 · 28bac1c · 28bac1c
1 parent cc7f1b0
commit 28bac1c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -26,7 +26,6 @@ export const expectedFailures = new Set([
     'slot-not-at-top-level/with-adjacent-text-nodes/lwcIf/light/index.js',
     'slot-not-at-top-level/with-adjacent-text-nodes/if/light/index.js',
     'slot-not-at-top-level/with-adjacent-text-nodes/if-as-sibling/light/index.js',
-    'superclass/with-props/index.js',
     'wire/errors/throws-on-computed-key/index.js',
     'wire/errors/throws-when-colliding-prop-then-method/index.js',
 ]);
diff --git a/packages/@lwc/ssr-compiler/src/compile-js/index.ts b/packages/@lwc/ssr-compiler/src/compile-js/index.ts
@@ -168,7 +168,11 @@ const visitors: Visitors = {
 
         switch (node.key.name) {
             case 'constructor':
-                node.value.params = [b.identifier('propsAvailableAtConstruction')];
+                // add our own custom arg after any pre-existing constructor args
+                node.value.params = [
+                    ...structuredClone(node.value.params),
+                    b.identifier('propsAvailableAtConstruction'),
+                ];
                 break;
             case 'connectedCallback':
                 state.hasConnectedCallback = true;
@@ -196,7 +200,11 @@ const visitors: Visitors = {
             path.parentPath &&
             path.parentPath.node?.type === 'CallExpression'
         ) {
-            path.parentPath.node.arguments = [b.identifier('propsAvailableAtConstruction')];
+            // add our own custom arg after any pre-existing super() args
+            path.parentPath.node.arguments = [
+                ...structuredClone(path.parentPath.node.arguments),
+                b.identifier('propsAvailableAtConstruction'),
+            ];
         }
     },
     Program: {