perf: optimize isHydrating (#2562)

salesforce · Nov 3, 2021 · 8e9c84d · 8e9c84d
1 parent 4420492
commit 8e9c84d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/@lwc/engine-core/src/framework/renderer.ts b/packages/@lwc/engine-core/src/framework/renderer.ts
@@ -10,7 +10,7 @@ export type HostElement = any;
 
 export interface Renderer<N = HostNode, E = HostElement> {
     ssr: boolean;
-    readonly isHydrating: boolean;
+    isHydrating(): boolean;
     isNativeShadowDefined: boolean;
     isSyntheticShadowDefined: boolean;
     insert(node: N, parent: E, anchor: N | null): void;

diff --git a/packages/@lwc/engine-core/src/framework/stylesheet.ts b/packages/@lwc/engine-core/src/framework/stylesheet.ts
@@ -194,7 +194,7 @@ export function createStylesheet(vm: VM, stylesheets: string[]): VNode | null {
         for (let i = 0; i < stylesheets.length; i++) {
             renderer.insertGlobalStylesheet(stylesheets[i]);
         }
-    } else if (renderer.ssr || renderer.isHydrating) {
+    } else if (renderer.ssr || renderer.isHydrating()) {
         // Note: We need to ensure that during hydration, the stylesheets method is the same as those in ssr.
         //       This works in the client, because the stylesheets are created, and cached in the VM
         //       the first time the VM renders.

diff --git a/packages/@lwc/engine-dom/src/renderer.ts b/packages/@lwc/engine-dom/src/renderer.ts
@@ -151,7 +151,7 @@ export function setIsHydrating(v: boolean) {
 
 export const renderer: Renderer<Node, Element> = {
     ssr: false,
-    get isHydrating(): boolean {
+    isHydrating(): boolean {
         return isHydrating;
     },
 

diff --git a/packages/@lwc/engine-server/src/renderer.ts b/packages/@lwc/engine-server/src/renderer.ts
@@ -61,7 +61,7 @@ class HTMLElement {
 
 export const renderer: Renderer<HostNode, HostElement> = {
     ssr: true,
-    get isHydrating(): boolean {
+    isHydrating(): boolean {
         return false;
     },