Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): @lwc/node-reactions #1747

Closed
wants to merge 10 commits into from

Conversation

ravijayaramappa
Copy link
Contributor

@ravijayaramappa ravijayaramappa commented Feb 29, 2020

Details

Library to react to dom elements connecting and disconnecting from the document
RFC: salesforce/lwc-rfcs#11

#Original PR
#1504

POC

#1431

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

GUS work item

W-6352642

@ravijayaramappa ravijayaramappa changed the title Ravi/node reactions review/rebase feat(engine): @lwc/node-reactions Feb 29, 2020
@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 9.1% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

lwc-engine-benchmark

✅ Improvements base (2876896) target (1abe517) trend
table-clear-1k.benchmark/benchmark-table/clear/1k 12.33 (± 0.22ms) 6.92 (± 0.40ms) -5.4ms (43.9%)
❌ Regressions base (2876896) target (1abe517) trend
table-append-1k.benchmark/benchmark-table/append/1k 266.67 (± 1.78ms) 292.31 (± 2.22ms) +25.6ms (9.6%)
table-create-10k.benchmark/benchmark-table/create/10k 1462.48 (± 8.83ms) 1566.03 (± 12.66ms) +103.5ms (7.1%)
table-create-1k.benchmark/benchmark-table/create/1k 157.62 (± 1.60ms) 179.64 (± 1.02ms) +22.0ms (14.0%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 390.02 (± 3.35ms) 432.05 (± 3.51ms) +42.0ms (10.8%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 6.01 (± 0.20ms) 12.22 (± 0.30ms) +6.2ms (103.2%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 2332.62 (± 15.85ms) 2559.31 (± 13.30ms) +226.7ms (9.7%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 29.01 (± 0.46ms) 39.38 (± 0.71ms) +10.4ms (35.7%)

@ravijayaramappa
Copy link
Contributor Author

This branch is old and not updated. It will be superseded by #2032

@ravijayaramappa ravijayaramappa deleted the ravi/node-reactions-review/rebase branch January 19, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant