refactor(engine): addEventListener restriction options param #1826
+32
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aputinski
changed the title
aputinski
changed the title
pmdartus
changed the title
pmdartus
changed the title
caridy
reviewed
Apr 14, 2020
Adding an event listener on the custom element with a third options argument logs an error. This restriction should be on the component instance and not on the host element. From the outside world, a DOM element should behave per spec when addEventListener is invoked with the options param, regardless of whether the element is a standard html element or a native custom element or an LWC host element.
|
Ok, this code is now ready, but after discussing the details with @ravijayaramappa, we looked at the code, and in fact, the custom element is being patched, eliminating the ability to use options when using synthetic shadow. We have found a couple of ways to allow this, but we will have to put some time to solve this. |
|
Closing this PR based on @caridy's feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Closes #1824
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.GUS work item
W-7446526